Skip to content

Commit 4483e5e

Browse files
committed
Added two additional test cases to ensure that records ending with a
subfield indicator are handeled correctly (see issue #137)
1 parent b6215cc commit 4483e5e

File tree

1 file changed

+32
-0
lines changed

1 file changed

+32
-0
lines changed

src/test/java/org/culturegraph/mf/stream/converter/bib/PicaDecoderTest.java

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,39 @@ public void testShouldFixIncompleteRecordIfConfigured() {
300300
verify028AEnd(ordered);
301301
ordered.verify(receiver).endRecord();
302302
}
303+
304+
305+
@Test(expected=FormatException.class)
306+
public void testShouldFailIfRecordEndsWithSubfieldIndicatorByDefault() {
307+
picaDecoder.process(
308+
FIELD_001AT +
309+
FIELD_003AT +
310+
FIELD_028A_START +
311+
SUBFIELD_A +
312+
EMPTY_SUBFIELD);
313+
}
303314

315+
@Test
316+
public void testShouldFixRecordEndingWithSubfieldIndicatorIfConfigured() {
317+
picaDecoder.setFixUnexpectedEOR(true);
318+
319+
picaDecoder.process(
320+
FIELD_001AT +
321+
FIELD_003AT +
322+
FIELD_028A_START +
323+
SUBFIELD_A +
324+
EMPTY_SUBFIELD);
325+
326+
final InOrder ordered = inOrder(receiver);
327+
ordered.verify(receiver).startRecord(RECORD_ID);
328+
verify001At(ordered);
329+
verify003At(ordered);
330+
verify028AStart(ordered);
331+
verifySubfieldA(ordered);
332+
verify028AEnd(ordered);
333+
ordered.verify(receiver).endRecord();
334+
}
335+
304336
@Test
305337
public void testShouldNotNormalizeUTF8ByDefault() {
306338
picaDecoder.process(

0 commit comments

Comments
 (0)