Skip to content

Commit 527c24d

Browse files
committed
Fix javadoc for module "javaintegration" (#396)
Also simplifies some constructors.
1 parent e3785d9 commit 527c24d

File tree

5 files changed

+20
-17
lines changed

5 files changed

+20
-17
lines changed

metafacture-javaintegration/src/main/java/org/metafacture/javaintegration/NamedValueList.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,17 @@
3434
public final class NamedValueList extends DefaultStreamReceiver implements List<NamedValue>, Collector<List<NamedValue>> {
3535

3636
private Collection<List<NamedValue>> collection;
37-
private List<NamedValue> list;
37+
private List<NamedValue> list = new ArrayList<NamedValue>();
3838

3939
public NamedValueList() {
40-
list = new ArrayList<NamedValue>();
4140
}
4241

42+
/**
43+
* Constructs a NamedValueList with a given Collection.
44+
*
45+
* @param collection the Collection
46+
*/
4347
public NamedValueList(final Collection<List<NamedValue>> collection) {
44-
list = new ArrayList<NamedValue>();
4548
this.collection = collection;
4649
}
4750

metafacture-javaintegration/src/main/java/org/metafacture/javaintegration/NamedValueSet.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,9 @@
3333
public final class NamedValueSet extends DefaultStreamReceiver implements Set<NamedValue>, Collector<Set<NamedValue>> {
3434

3535
private Collection<Set<NamedValue>> collection;
36-
private Set<NamedValue> set;
36+
private Set<NamedValue> set = new HashSet<>();
3737

3838
public NamedValueSet() {
39-
set = new HashSet<>();
40-
this.collection = null;
41-
4239
}
4340

4441
/**
@@ -48,7 +45,6 @@ public NamedValueSet() {
4845
* @param collection is filled with the received results.
4946
*/
5047
public NamedValueSet(final Collection<Set<NamedValue>> collection) {
51-
set = new HashSet<>();
5248
this.collection = collection;
5349
}
5450

metafacture-javaintegration/src/main/java/org/metafacture/javaintegration/StringListMapToStream.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ public void process(final ListMap<String, String> listMap) {
4646
process(listMap, getReceiver());
4747
}
4848

49+
/**
50+
* Reads a {@link ListMap} and sends it to a {@link StreamReceiver}.
51+
*
52+
* @param listMap the ListMap to be read
53+
* @param receiver the StreamReceiver to send to
54+
*/
4955
public static void process(final ListMap<String, String> listMap, final StreamReceiver receiver) {
5056
receiver.startRecord(listMap.getId());
5157
for (final Entry<String, List<String>> entry: listMap.entrySet()) {

metafacture-javaintegration/src/main/java/org/metafacture/javaintegration/StringMap.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,17 @@ public final class StringMap extends DefaultStreamReceiver implements Map<String
3333

3434
private boolean closed;
3535
private Collection<Map<String, String>> collection;
36-
private Map<String, String> map;
36+
private Map<String, String> map = new HashMap<String, String>();
3737

3838
public StringMap() {
39-
map = new HashMap<String, String>();
40-
collection = null;
4139
}
4240

41+
/**
42+
* Constructs a StringMap with a given Collection.
43+
*
44+
* @param collection the Collection
45+
*/
4346
public StringMap(final Collection<Map<String, String>> collection) {
44-
map = new HashMap<String, String>();
4547
this.collection = collection;
4648
}
4749

metafacture-javaintegration/src/main/java/org/metafacture/javaintegration/ValueSet.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,10 @@
3131
*/
3232
public final class ValueSet extends DefaultStreamReceiver implements Set<String>, Collector<Set<String>> {
3333

34-
private Collection<Set<String>> collection;
34+
private Collection<Set<String>> collection = new HashSet<>();
3535
private Set<String> set;
3636

3737
public ValueSet() {
38-
set = new HashSet<>();
39-
this.collection = null;
40-
4138
}
4239

4340
/**
@@ -47,7 +44,6 @@ public ValueSet() {
4744
* @param collection is filled with the received results.
4845
*/
4946
public ValueSet(final Collection<Set<String>> collection) {
50-
set = new HashSet<>();
5147
this.collection = collection;
5248
}
5349

0 commit comments

Comments
 (0)