Skip to content

Commit 540f43f

Browse files
committed
Update TODOs on implicit append in unit & integration tests (#170)
1 parent 5e5bf5f commit 540f43f

File tree

2 files changed

+3
-2
lines changed
  • metafix/src/test
    • java/org/metafacture/metafix
    • resources/org/metafacture/metafix/integration/record/fromJson/toJson/copy_fieldToSubfieldOfArrayOfObjectsWithIndexGeneratingNewObject

2 files changed

+3
-2
lines changed

metafix/src/test/java/org/metafacture/metafix/MetafixMethodTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1626,7 +1626,7 @@ public void multipleReplaceAllWithWildcardAfterCopyFieldWithVarInSourceAndTarget
16261626
}
16271627

16281628
@Test
1629-
@MetafixToDo("See https://github.com/metafacture/metafacture-fix/pull/170")
1629+
@MetafixToDo("Do we actually want implicit append? WDCD? See (passing) copyFieldToSubfieldOfArrayOfStringsWithIndexImplicitAppend")
16301630
public void copyFieldToSubfieldOfArrayOfObjectsWithIndexImplicitAppend() {
16311631
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
16321632
"set_array('test[]')",
@@ -1650,6 +1650,7 @@ public void copyFieldToSubfieldOfArrayOfObjectsWithIndexImplicitAppend() {
16501650
}
16511651

16521652
@Test
1653+
// Do we actually want implicit append? WDCD? See (failing) copyFieldToSubfieldOfArrayOfObjectsWithIndexImplicitAppend
16531654
public void copyFieldToSubfieldOfArrayOfStringsWithIndexImplicitAppend() {
16541655
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
16551656
"set_array('test[]')",
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
See PR #170. Do we actually want implicit append? WDCD?
1+
Do we actually want implicit append? WDCD? See MetafixMethodTest#*WithIndexImplicitAppend tests.

0 commit comments

Comments
 (0)