Make generic XML handler value tag name configurable.

Author: blackwinter

metafacture-xml/src/main/java/org/metafacture/xml/GenericXmlHandler.java

@@ -44,12 +44,15 @@ public final class GenericXmlHandler extends DefaultXmlPipe<StreamReceiver> {
 
     public static final String DEFAULT_RECORD_TAG = "record";
 
+    public static final String DEFAULT_VALUE_TAG = "value";
+
     public static final boolean EMIT_NAMESPACE = false;
 
     private static final Pattern TABS = Pattern.compile("\t+");
 
     private String attributeMarker = DEFAULT_ATTRIBUTE_MARKER;
     private String recordTagName = DEFAULT_RECORD_TAG;
+    private String valueTagName = DEFAULT_VALUE_TAG;
 
     private boolean inRecord;
     private StringBuilder valueBuffer = new StringBuilder();
@@ -95,6 +98,14 @@ public String getRecordTagName() {
         return recordTagName;
     }
 
+    public void setValueTagName(final String valueTagName) {
+        this.valueTagName = valueTagName;
+    }
+
+    public String getValueTagName() {
+        return valueTagName;
+    }
+
     /**
      * Triggers namespace awareness. If set to "true" input data like "foo:bar"
      * will be passed through as "foo:bar". For backward compatibility the default
@@ -170,7 +181,7 @@ public void characters(final char[] chars, final int start, final int length) {
     private void writeValue() {
         final String value = valueBuffer.toString();
         if (!value.trim().isEmpty()) {
-            getReceiver().literal("value", value.replace('\n', ' '));
+            getReceiver().literal(valueTagName, value.replace('\n', ' '));
         }
         valueBuffer = new StringBuilder();
     }

metafacture-xml/src/test/java/org/metafacture/xml/GenericXMLHandlerTest.java

@@ -133,6 +133,28 @@ public void shouldEmitPCDataAsALiteralNamedValue() {
         ordered.verify(receiver).literal("value", "char-data");
     }
 
+    @Test
+    public void shouldEmitPCDataAsALiteralWithConfiguredValueTagName() {
+        final String name = "data";
+        genericXmlHandler.setValueTagName(name);
+
+        final char[] charData = "char-data".toCharArray();
+        genericXmlHandler.startElement("", "record", "record", attributes);
+        genericXmlHandler.startElement("", "entity", "entity", attributes);
+        genericXmlHandler.characters(charData, 0, charData.length);
+        genericXmlHandler.endElement("", "entity", "entity");
+        genericXmlHandler.endElement("", "record", "record");
+
+        final InOrder ordered = inOrder(receiver);
+        ordered.verify(receiver).startRecord("");
+        ordered.verify(receiver).startEntity("entity");
+        ordered.verify(receiver).literal(name, "char-data");
+        ordered.verify(receiver).endEntity();
+        ordered.verify(receiver).endRecord();
+        ordered.verifyNoMoreInteractions();
+        Mockito.verifyNoMoreInteractions(receiver);
+    }
+
     @Test
     public void shouldEmitNamespaceOnEntityElementAndAttribute() {
         genericXmlHandler.setEmitNamespace(true);