metamorph-test/ (main): Fix Checkstyle violations.

Author: blackwinter

metamorph-test/src/main/java/org/metafacture/metamorph/test/MetamorphTestCase.java

@@ -13,13 +13,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.metafacture.metamorph.test;
 
-import java.io.FileNotFoundException;
-import java.io.StringReader;
+package org.metafacture.metamorph.test;
 
-import org.junit.runners.model.InitializationError;
-import org.junit.runners.model.Statement;
 import org.metafacture.commons.ResourceUtil;
 import org.metafacture.commons.XmlUtil;
 import org.metafacture.commons.reflection.ReflectionUtil;
@@ -30,20 +26,25 @@
 import org.metafacture.metamorph.test.reader.MultiFormatReader;
 import org.metafacture.metamorph.test.reader.Reader;
 import org.metafacture.metamorph.test.validators.StreamValidator;
+
+import org.junit.runners.model.InitializationError;
+import org.junit.runners.model.Statement;
 import org.w3c.dom.Element;
 import org.w3c.dom.NodeList;
 import org.xml.sax.InputSource;
 
+import java.io.FileNotFoundException;
+import java.io.StringReader;
+
 /**
  * Runs a test defined in a Metamorph-Test definition.
  *
  * @author Christoph Böhme
  *
  */
-final class MetamorphTestCase extends Statement {
+final class MetamorphTestCase extends Statement { // checkstyle-disable-line ClassDataAbstractionCoupling
 
-    private static final String NO_DATA_FOUND =
-            "Please specify either element content or a src attribute";
+    private static final String NO_DATA_FOUND = "Please specify either element content or a src attribute";
 
     private static final String NAME_ATTR = "name";
     private static final String IGNORE_ATTR = "ignore";
@@ -77,20 +78,23 @@ public boolean isIgnore() {
     public void evaluate() throws InitializationError {
         final Reader inputReader = getReader(INPUT_TAG);
         @SuppressWarnings("unchecked")
-        final StreamPipe<StreamReceiver>transformation = getTransformation();
+        final StreamPipe<StreamReceiver> transformation = getTransformation();
         final EventList resultStream = new EventList();
 
         if (transformation == null) {
             inputReader.setReceiver(resultStream);
-        } else {
+        }
+        else {
             inputReader.setReceiver(transformation).setReceiver(resultStream);
         }
 
         inputReader.process(getInputData());
         inputReader.closeStream();
 
         final StreamValidator validator = new StreamValidator(resultStream.getEvents());
-        validator.setErrorHandler(msg -> { throw new AssertionError(msg); });
+        validator.setErrorHandler(msg -> {
+            throw new AssertionError(msg);
+        });
 
         final Element result = (Element) config.getElementsByTagName(RESULT_TAG).item(0);
         validator.setStrictRecordOrder(Boolean.parseBoolean(
@@ -113,8 +117,7 @@ private Reader getReader(final String tag) {
         return new MultiFormatReader(mimeType);
     }
 
-    @SuppressWarnings("rawtypes")
-    private StreamPipe getTransformation() throws InitializationError {
+    private StreamPipe getTransformation() throws InitializationError { // checkstyle-disable-line ReturnCount
         final NodeList nodes = config.getElementsByTagName(TRANSFORMATION_TAG);
         if (nodes.getLength() == 0) {
             return null;
@@ -133,7 +136,8 @@ private StreamPipe getTransformation() throws InitializationError {
             }
             return new Metamorph(src);
 
-        } else if (MIME_JAVACLASS.equals(type)) {
+        }
+        else if (MIME_JAVACLASS.equals(type)) {
             if (src.isEmpty()) {
                 throw new InitializationError(
                         "class defining transformation not specified");
@@ -165,7 +169,8 @@ private java.io.Reader getDataFromSource(final String src)
             throws InitializationError {
         try {
             return ResourceUtil.getReader(src);
-        } catch (final FileNotFoundException e) {
+        }
+        catch (final FileNotFoundException e) {
             throw new InitializationError("Could not find input file '" + src +
                     "': " + e.getMessage());
         }

metamorph-test/src/main/java/org/metafacture/metamorph/test/MetamorphTestLoader.java

@@ -1,4 +1,4 @@
-    /*
+/*
  * Copyright 2013, 2014 Deutsche Nationalbibliothek
  *
  * Licensed under the Apache License, Version 2.0 the "License";
@@ -13,28 +13,27 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.metamorph.test;
 
+import org.junit.runners.model.InitializationError;
+import org.w3c.dom.Document;
+import org.w3c.dom.Element;
+import org.w3c.dom.NodeList;
+import org.xml.sax.InputSource;
+import org.xml.sax.SAXException;
+
 import java.io.IOException;
 import java.net.URL;
 import java.util.ArrayList;
 import java.util.List;
-
 import javax.xml.XMLConstants;
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
 import javax.xml.validation.Schema;
 import javax.xml.validation.SchemaFactory;
 
-import org.junit.runners.model.InitializationError;
-import org.w3c.dom.Document;
-import org.w3c.dom.Element;
-import org.w3c.dom.NodeList;
-import org.xml.sax.InputSource;
-import org.xml.sax.SAXException;
-
-
 /**
  * Utility methods for loading Metamorph-Test resources.
  *
@@ -81,17 +80,17 @@ private static List<MetamorphTestCase> load(final InputSource inputSource)
 
             final List<MetamorphTestCase> metamorphTestCases = new ArrayList<>();
             final NodeList testCaseNodes = doc.getElementsByTagName(TEST_CASE_TAG);
-            for(int i=0; i < testCaseNodes.getLength(); ++i) {
+            for (int i = 0; i < testCaseNodes.getLength(); ++i) {
                 final Element testCaseElement = (Element) testCaseNodes.item(i);
                 metamorphTestCases.add(new MetamorphTestCase(testCaseElement));
             }
 
             return metamorphTestCases;
 
-        } catch (final ParserConfigurationException|SAXException|IOException e) {
+        }
+        catch (final ParserConfigurationException | SAXException | IOException e) {
             throw new InitializationError(e);
         }
     }
 
 }
-

metamorph-test/src/main/java/org/metafacture/metamorph/test/MetamorphTestRunner.java

@@ -13,16 +13,17 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.metafacture.metamorph.test;
 
-import java.net.URL;
-import java.util.List;
+package org.metafacture.metamorph.test;
 
 import org.junit.runner.Description;
 import org.junit.runner.notification.RunNotifier;
 import org.junit.runners.ParentRunner;
 import org.junit.runners.model.InitializationError;
 
+import java.net.URL;
+import java.util.List;
+
 /**
  * Executes test cases defined in a metamorph-test file.
  *
@@ -71,7 +72,8 @@ protected void runChild(final MetamorphTestCase child,
         final Description description = describeChild(child);
         if (child.isIgnore()) {
             notifier.fireTestIgnored(description);
-        } else {
+        }
+        else {
             runLeaf(child, description, notifier);
         }
     }

metamorph-test/src/main/java/org/metafacture/metamorph/test/MetamorphTestSuite.java

@@ -13,21 +13,22 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.metamorph.test;
 
+import org.junit.runner.Description;
+import org.junit.runner.Runner;
+import org.junit.runner.notification.RunNotifier;
+import org.junit.runners.ParentRunner;
+import org.junit.runners.model.InitializationError;
+
 import java.lang.annotation.ElementType;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 import java.util.ArrayList;
 import java.util.List;
 
-import org.junit.runner.Description;
-import org.junit.runner.Runner;
-import org.junit.runner.notification.RunNotifier;
-import org.junit.runners.ParentRunner;
-import org.junit.runners.model.InitializationError;
-
 /**
  * Binds a list of Metamorph-Test resources to a class.
  *
@@ -45,18 +46,16 @@ public MetamorphTestSuite(final Class<?> suiteRoot)
         runners = loadDefinitions(suiteRoot);
     }
 
-    private static List<Runner> loadDefinitions(final Class<?> suiteRoot)
-            throws InitializationError{
+    private static List<Runner> loadDefinitions(final Class<?> suiteRoot) throws InitializationError {
         final List<Runner> runners = new ArrayList<>();
         for (final String testDef : getTestDefinitionNames(suiteRoot)) {
             runners.add(new MetamorphTestRunner(suiteRoot, testDef));
         }
         return runners;
     }
 
-    private static String[] getTestDefinitionNames(final Class<?> suiteRoot){
-        final TestDefinitions testDefs =
-                suiteRoot.getAnnotation(TestDefinitions.class);
+    private static String[] getTestDefinitionNames(final Class<?> suiteRoot) {
+        final TestDefinitions testDefs = suiteRoot.getAnnotation(TestDefinitions.class);
         if (testDefs == null) {
             // if no xmls are given assume an xml with the same name as the class:
             return new String[]{suiteRoot.getSimpleName() + ".xml"};

metamorph-test/src/main/java/org/metafacture/metamorph/test/reader/CGXmlReader.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.metamorph.test.reader;
 
 import org.metafacture.xml.CGXmlHandler;

metamorph-test/src/main/java/org/metafacture/metamorph/test/reader/FormetaReader.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.metamorph.test.reader;
 
 import org.metafacture.formeta.FormetaDecoder;

metamorph-test/src/main/java/org/metafacture/metamorph/test/reader/JsonLinesReader.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.metamorph.test.reader;
 
 import org.metafacture.io.LineReader;

metamorph-test/src/main/java/org/metafacture/metamorph/test/reader/JsonReader.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.metamorph.test.reader;
 
 import org.metafacture.io.RecordReader;

metamorph-test/src/main/java/org/metafacture/metamorph/test/reader/MarcXmlReader.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.metamorph.test.reader;
 
 import org.metafacture.biblio.marc21.MarcXmlHandler;

metamorph-test/src/main/java/org/metafacture/metamorph/test/reader/MultiFormatReader.java

@@ -13,11 +13,11 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.metamorph.test.reader;
 
 import org.metafacture.framework.StreamReceiver;
 
-
 /**
  * Dynamically instantiated a reader for a specific data format. This module
  * allows to select a concrete reader only at runtime.
@@ -36,9 +36,8 @@ public MultiFormatReader(final String format) {
     }
 
     public void setFormat(final String format) {
-        if(!READER_FACTORY.containsKey(format)){
-            throw new IllegalArgumentException("Format '" + format +
-                    "' not regognized");
+        if (!READER_FACTORY.containsKey(format)) {
+            throw new IllegalArgumentException("Format '" + format + "' not regognized");
         }
         currentReader = READER_FACTORY.newInstance(format);
         currentReader.setReceiver(downstreamReceiver);