Skip to content

Commit 6da63b8

Browse files
committed
Fix insecure configuration
Log using logger.
1 parent e132278 commit 6da63b8

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

metafacture-html/src/main/java/org/metafacture/html/HtmlDecoder.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636
import org.metafacture.framework.annotations.In;
3737
import org.metafacture.framework.annotations.Out;
3838
import org.metafacture.framework.helpers.DefaultObjectPipe;
39+
import org.slf4j.Logger;
40+
import org.slf4j.LoggerFactory;
3941

4042
/**
4143
* Decode HTML to metadata events. Each input document represents one record.
@@ -60,6 +62,8 @@ public class HtmlDecoder extends DefaultObjectPipe<Reader, StreamReceiver> {
6062
private static final String DEFAULT_ATTR_VALS_AS_SUBFIELDS = //
6163
"meta.name=content&meta.property=content&link.rel=href&a.rel=href";
6264
private Map<String, String> attrValsAsSubfields;
65+
private static final Logger LOG =
66+
LoggerFactory.getLogger(HtmlDecoder.class);
6367

6468
public HtmlDecoder() {
6569
setAttrValsAsSubfields(DEFAULT_ATTR_VALS_AS_SUBFIELDS);
@@ -74,7 +78,7 @@ public void process(final Reader reader) {
7478
process(document, receiver);
7579
receiver.endRecord();
7680
} catch (IOException e) {
77-
e.printStackTrace();
81+
LOG.error(e.getMessage(), e);
7882
}
7983
}
8084

@@ -127,7 +131,7 @@ public void setAttrValsAsSubfields(String mapString) {
127131
String val = nameValue.length > 1 ? URLDecoder.decode(nameValue[1], utf8) : "";
128132
attrValsAsSubfields.put(key, val);
129133
} catch (UnsupportedEncodingException e) {
130-
e.printStackTrace();
134+
LOG.error(e.getMessage(), e);
131135
}
132136
}
133137
}

0 commit comments

Comments
 (0)