metafacture-flowcontrol/ (main): Fix Checkstyle violations.

Author: blackwinter

metafacture-flowcontrol/src/main/java/org/metafacture/flowcontrol/CloseSuppressor.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.flowcontrol;
 
 import org.metafacture.framework.FluxCommand;
@@ -59,9 +60,9 @@ public void process(final T obj) {
     }
 
     @Override
-    public <R extends ObjectReceiver<T>> R setReceiver(final R receiver) {
-        this.receiver = receiver;
-        return receiver;
+    public <R extends ObjectReceiver<T>> R setReceiver(final R newReceiver) {
+        receiver = newReceiver;
+        return newReceiver;
     }
 
     @Override

metafacture-flowcontrol/src/main/java/org/metafacture/flowcontrol/ObjectBatchResetter.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.flowcontrol;
 
 import org.metafacture.framework.FluxCommand;
@@ -41,6 +42,9 @@ public class ObjectBatchResetter<T> extends DefaultObjectPipe<T, ObjectReceiver<
     private long batchCount;
     private int objectCount;
 
+    public ObjectBatchResetter() {
+    }
+
     /**
      * Number of objects after which a <i>reset-stream</i> event is triggered.
      * <p>
@@ -53,8 +57,7 @@ public class ObjectBatchResetter<T> extends DefaultObjectPipe<T, ObjectReceiver<
      * @param batchSize number of objects before a <i>reset-stream</i> event is
      *                  triggered
      */
-    public void setBatchSize(int batchSize) {
-
+    public void setBatchSize(final int batchSize) {
         this.batchSize = batchSize;
     }
 

metafacture-flowcontrol/src/main/java/org/metafacture/flowcontrol/ObjectExceptionCatcher.java

@@ -13,20 +13,21 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.metafacture.flowcontrol;
 
-import java.io.PrintWriter;
-import java.io.StringWriter;
+package org.metafacture.flowcontrol;
 
 import org.metafacture.framework.FluxCommand;
 import org.metafacture.framework.ObjectReceiver;
 import org.metafacture.framework.annotations.Description;
 import org.metafacture.framework.annotations.In;
 import org.metafacture.framework.annotations.Out;
 import org.metafacture.framework.helpers.DefaultObjectPipe;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.io.PrintWriter;
+import java.io.StringWriter;
 
 /**
  * Wraps the call to the process method of the downstream module
@@ -57,7 +58,6 @@ public ObjectExceptionCatcher() {
     }
 
     public ObjectExceptionCatcher(final String logPrefix) {
-        super();
         this.logPrefix = logPrefix;
     }
 
@@ -81,7 +81,8 @@ public boolean isLogStackTrace() {
     public void process(final T obj) {
         try {
             getReceiver().process(obj);
-        } catch(final Exception e) {
+        }
+        catch (final Exception e) { // checkstyle-disable-line IllegalCatch
             LOG.error("{}'{}' while processing object: {}", logPrefix, e.getMessage(), obj);
 
             if (logStackTrace) {

metafacture-flowcontrol/src/main/java/org/metafacture/flowcontrol/ObjectPipeDecoupler.java

@@ -13,20 +13,22 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.metafacture.flowcontrol;
 
-import java.util.concurrent.BlockingQueue;
-import java.util.concurrent.LinkedBlockingQueue;
+package org.metafacture.flowcontrol;
 
 import org.metafacture.framework.FluxCommand;
 import org.metafacture.framework.ObjectPipe;
 import org.metafacture.framework.ObjectReceiver;
 import org.metafacture.framework.annotations.Description;
 import org.metafacture.framework.annotations.In;
 import org.metafacture.framework.annotations.Out;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+
 /**
  * Creates a new thread in which subsequent flow elements run.
  *
@@ -76,7 +78,8 @@ public void process(final T obj) {
             if (debug) {
                 LOG.info("Current buffer size: {}", queue.size());
             }
-        } catch (InterruptedException e) {
+        }
+        catch (final InterruptedException e) {
             Thread.currentThread().interrupt();
         }
     }
@@ -87,20 +90,21 @@ private void start() {
     }
 
     @Override
-    public <R extends ObjectReceiver<T>> R setReceiver(final R receiver) {
+    public <R extends ObjectReceiver<T>> R setReceiver(final R newReceiver) {
         if (null != thread) {
             throw new IllegalStateException("Receiver cannot be changed while processing thread is running.");
         }
 
-        this.receiver = receiver;
-        return receiver;
+        receiver = newReceiver;
+        return newReceiver;
     }
 
     @Override
     public void resetStream() {
         try {
             queue.put(Feeder.BLUE_PILL);
-        } catch (InterruptedException e) {
+        }
+        catch (final InterruptedException e) {
             Thread.currentThread().interrupt();
         }
     }
@@ -110,7 +114,8 @@ public void closeStream() {
         try {
             queue.put(Feeder.RED_PILL);
             thread.join();
-        } catch (InterruptedException e) {
+        }
+        catch (final InterruptedException e) {
             Thread.currentThread().interrupt();
         }
         thread = null;
@@ -128,7 +133,7 @@ static final class Feeder<T> implements Runnable {
         private final ObjectReceiver<T> receiver;
         private final BlockingQueue<Object> queue;
 
-        public Feeder(final ObjectReceiver<T> receiver, final BlockingQueue<Object> queue) {
+        Feeder(final ObjectReceiver<T> receiver, final BlockingQueue<Object> queue) {
             this.receiver = receiver;
             this.queue = queue;
         }
@@ -150,7 +155,8 @@ public void run() {
                     }
                     receiver.process((T) object);
                 }
-            } catch (InterruptedException e) {
+            }
+            catch (final InterruptedException e) {
                 Thread.currentThread().interrupt();
                 return;
             }

metafacture-flowcontrol/src/main/java/org/metafacture/flowcontrol/ObjectThreader.java

@@ -15,19 +15,20 @@
 
 package org.metafacture.flowcontrol;
 
-import java.util.ArrayList;
-import java.util.List;
-
 import org.metafacture.framework.FluxCommand;
 import org.metafacture.framework.ObjectPipe;
 import org.metafacture.framework.ObjectReceiver;
 import org.metafacture.framework.Tee;
 import org.metafacture.framework.annotations.Description;
 import org.metafacture.framework.annotations.In;
 import org.metafacture.framework.annotations.Out;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.util.ArrayList;
+import java.util.List;
+
 /**
  * Divides incoming objects and distributes them to added receivers. These
  * receivers are coupled with an
@@ -48,22 +49,26 @@ public class ObjectThreader<T> implements Tee<ObjectReceiver<T>>, ObjectPipe<T,
 
     private static final Logger LOG = LoggerFactory.getLogger(ObjectThreader.class);
     private final List<ObjectReceiver<T>> receivers = new ArrayList<ObjectReceiver<T>>();
-    private int objectNumber = 0;
+    private int objectNumber;
+
+    public ObjectThreader() {
+    }
 
     @Override
     public void process(final T obj) {
         receivers.get(objectNumber).process(obj);
         if (objectNumber == receivers.size() - 1) {
             objectNumber = 0;
-        } else {
-            objectNumber++;
+        }
+        else {
+            ++objectNumber;
         }
     }
 
     @Override
     public Tee<ObjectReceiver<T>> addReceiver(final ObjectReceiver<T> receiver) {
-        LOG.info("Adding thread {}", (receivers.size() + 1));
-        ObjectPipeDecoupler<T> opd = new ObjectPipeDecoupler<>();
+        LOG.info("Adding thread {}", receivers.size() + 1);
+        final ObjectPipeDecoupler<T> opd = new ObjectPipeDecoupler<>();
         opd.setReceiver(receiver);
         receivers.add(opd);
         return this;
@@ -77,7 +82,7 @@ public <R extends ObjectReceiver<T>> R setReceiver(final R receiver) {
     }
 
     @Override
-    public <R extends ObjectReceiver<T>> R setReceivers(R receiver, ObjectReceiver<T> lateralReceiver) {
+    public <R extends ObjectReceiver<T>> R setReceivers(final R receiver, final ObjectReceiver<T> lateralReceiver) {
         receivers.clear();
         addReceiver(receiver);
         addReceiver(lateralReceiver);
@@ -95,7 +100,7 @@ public void closeStream() {
     }
 
     @Override
-    public Tee<ObjectReceiver<T>> removeReceiver(ObjectReceiver<T> receiver) {
+    public Tee<ObjectReceiver<T>> removeReceiver(final ObjectReceiver<T> receiver) {
         receivers.remove(receiver);
         return this;
     }

metafacture-flowcontrol/src/main/java/org/metafacture/flowcontrol/StreamBatchResetter.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.metafacture.flowcontrol;
 
 import org.metafacture.framework.FluxCommand;
@@ -40,35 +41,38 @@ public final class StreamBatchResetter extends ForwardingStreamPipe {
     private long recordCount;
     private long batchCount;
 
-    public final void setBatchSize(final int batchSize) {
+    public StreamBatchResetter() {
+    }
+
+    public void setBatchSize(final int batchSize) {
         this.batchSize = batchSize;
     }
 
-    public final long getBatchSize() {
+    public long getBatchSize() {
         return batchSize;
     }
 
-    public final long getBatchCount() {
+    public long getBatchCount() {
         return batchCount;
     }
 
-    public final long getRecordCount() {
+    public long getRecordCount() {
         return recordCount;
     }
 
     @Override
-    public final void endRecord() {
+    public void endRecord() {
         getReceiver().endRecord();
-        recordCount++;
+        ++recordCount;
         recordCount %= batchSize;
         if (recordCount == 0) {
-            batchCount++;
+            ++batchCount;
             getReceiver().resetStream();
         }
     }
 
     @Override
-    protected final void onResetStream() {
+    protected void onResetStream() {
         recordCount = 0;
         batchCount = 0;
     }