Skip to content

Commit a505fc5

Browse files
committed
Adjust delete function as suggested by @blackwinter #333
1 parent 5cb5e66 commit a505fc5

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

metafix/src/main/java/org/metafacture/metafix/FixMethod.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -517,10 +517,10 @@ public void apply(final Metafix metafix, final Record record, final List<String>
517517
map = metafix.getMap(mapName);
518518
}
519519

520-
final String defaultValue = map.get(Maps.DEFAULT_MAP_KEY); // TODO: Catmandu uses 'default'
520+
final String defaultOption = options.get("default");
521+
final String defaultValue = options.getOrDefault(Maps.DEFAULT_MAP_KEY, map.get(Maps.DEFAULT_MAP_KEY));
521522
final boolean delete = getBoolean(options, "delete");
522523
final boolean printUnknown = getBoolean(options, "print_unknown");
523-
final String defaultOption = options.get("default");
524524

525525
final Consumer<Consumer<String>> consumer = c -> record.transform(params.get(0), oldValue -> {
526526
final String newValue = map.get(oldValue);
@@ -531,11 +531,7 @@ public void apply(final Metafix metafix, final Record record, final List<String>
531531
if (c != null) {
532532
c.accept(oldValue);
533533
}
534-
elsif (defaultOption != null){
535-
return defaultOption;
536-
}
537-
return defaultValue != null ? defaultValue : delete ? null : oldValue;
538-
534+
return defaultOption != null ? defaultOption : defaultValue != null ? defaultValue : delete ? null : oldValue;
539535
}
540536
});
541537

0 commit comments

Comments
 (0)