Fix issues in tests for implicit array creation on $append (#127)

Author: fsteeg

metafix/src/test/java/org/metafacture/metafix/MetafixRecordTest.java

@@ -1462,11 +1462,9 @@ public void renameArrayOfHashes() {
     }
 
     @Test
-    @MetafixToDo("Do we actually need/want implicit $append? WDCD?")
     public void copyIntoArrayOfHashesImplicitAppend() {
         MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
-                "set_array('author[]')",
-                "copy_field('your.name','author[].name')",
+                "copy_field('your.name','author[].$append.name')",
                 "remove_field('your')"),
             i -> {
                 i.startRecord("1");

metafix/src/test/resources/org/metafacture/metafix/integration/record/fromJson/toJson/add_fieldAppendAndCreateNestedArrayOfObjects/expected.json

@@ -1,7 +1,7 @@
 {
   "test" : "test",
   "object" : {
-    "arrayOfObjects" : [ {
+    "arrayOfObject" : [ {
       "key" : "value"
     }, {
       "key" : "more_value"

metafix/src/test/resources/org/metafacture/metafix/integration/record/fromJson/toJson/add_fieldAppendAndCreateNestedArrayOfObjects/todo.txt

@@ -1,9 +1,9 @@
 {
-  "arrayOfObjects" : [ {
+  "key" : "value",
+  "key_2" : "more_value",
+  "arrayOfObject" : [ {
     "key" : "value"
   }, {
     "key" : "more_value"
-  } ],
-  "key" : "value",
-  "key_2" : "more_value"
+  } ]
 }

metafix/src/test/resources/org/metafacture/metafix/integration/record/fromJson/toJson/copy_fieldAppendAndCreateArrayOfObjects/expected.json

@@ -1,19 +1,19 @@
 {
-  "arrayOfObjects_1" : [ {
-    "arrayOfObjects_2" : [ {
+  "key" : "value",
+  "key_2" : "more_value",
+  "key_3" : "even_more_value",
+  "key_4" : "so_much_value",
+  "arrayOfObject_1" : [ {
+    "arrayOfObject_2" : [ {
       "key" : "value"
     }, {
       "key" : "more_value"
     } ]
   }, {
-    "arrayOfObjects_3" : [ {
+    "arrayOfObject_3" : [ {
       "key" : "even_more_value"
     }, {
       "key" : "so_much_value"
     } ]
-  } ],
-  "key" : "value",
-  "key_2" : "more_value",
-  "key_3" : "even_more_value",
-  "key_4" : "so_much_value"
+  } ]
 }

metafix/src/test/resources/org/metafacture/metafix/integration/record/fromJson/toJson/copy_fieldAppendAndCreateArrayOfObjects/todo.txt

@@ -1,9 +1,11 @@
 {
-  "arrayOfObjects" : [ {
-    "key" : "value"
-  }, {
-    "key" : "more_value"
-  } ],
   "key" : "value",
-  "key_2" : "more_value"
+  "key_2" : "more_value",
+  "object" : {
+    "arrayOfObject" : [ {
+      "key" : "value"
+    }, {
+      "key" : "more_value"
+    } ]
+  }
 }

metafix/src/test/resources/org/metafacture/metafix/integration/record/fromJson/toJson/copy_fieldAppendAndCreateArrayOfObjectsInArrayOfObjects/expected.json

@@ -1,7 +1,7 @@
 {
+  "key" : "value",
+  "key_2" : "more_value",
   "object" : {
     "test" : [ "value", "more_value" ]
-  },
-  "key" : "value",
-  "key_2" : "more_value"
+  }
 }