Skip to content

Commit f353d93

Browse files
committed
JScriptObjectPipe: Close script file resources.
1 parent 05eff68 commit f353d93

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

metafacture-scripting/src/main/java/org/metafacture/scripting/JScriptObjectPipe.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
import org.metafacture.framework.annotations.Out;
2626
import org.metafacture.framework.helpers.DefaultObjectPipe;
2727

28-
import java.io.FileNotFoundException;
28+
import java.io.IOException;
29+
import java.io.Reader;
2930
import javax.script.Invocable;
3031
import javax.script.ScriptEngine;
3132
import javax.script.ScriptEngineManager;
@@ -70,14 +71,14 @@ private void setScript(final String file) {
7071

7172
final ScriptEngineManager manager = new ScriptEngineManager();
7273
final ScriptEngine engine = manager.getEngineByName("JavaScript");
73-
try {
74+
try (Reader reader = ResourceUtil.getReader(file)) {
7475
// LOG.info("loading code from '" + file + "'");
75-
engine.eval(ResourceUtil.getReader(file));
76+
engine.eval(reader);
7677
}
7778
catch (final ScriptException e) {
7879
throw new MetafactureException("Error in script", e);
7980
}
80-
catch (final FileNotFoundException e) {
81+
catch (final IOException e) {
8182
throw new MetafactureException("Error loading script '" + file + "'", e);
8283
}
8384
invocable = (Invocable) engine;

0 commit comments

Comments
 (0)