chore(deps): upgrade golangci-lint (#83)

Author: vknabel

.github/workflows/lint.yml

@@ -24,7 +24,7 @@ jobs:
           cache: false
 
       - name: Run Linter
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
 
       - name: Check spelling
         uses: crate-ci/typos@master

.golangci.yml

@@ -1,45 +1,44 @@
+version: "2"
 run:
-  timeout: 5m
   allow-parallel-runners: true
-
-issues:
-  # don't skip warning about doc comments
-  # don't exclude the default set of lint
-  exclude-use-default: false
-  # restore some of the defaults
-  # (fill in the rest as needed)
-  exclude-rules:
-    - path: "api/*"
-      linters:
-        - lll
-    - path: "internal/*"
-      linters:
-        - dupl
-        - lll
 linters:
   enable:
     - copyloopvar
     - dupl
-    - errcheck
     - ginkgolinter
     - goconst
     - gocyclo
-    - gofmt
-    - goimports
-    - gosimple
-    - govet
-    - ineffassign
     - misspell
     - nakedret
     - prealloc
     - revive
-    - staticcheck
-    - typecheck
     - unconvert
     - unparam
-    - unused
-
-linters-settings:
-  revive:
+  settings:
+    revive:
+      rules:
+        - name: comment-spacings
+  exclusions:
+    generated: lax
     rules:
-      - name: comment-spacings
+      - linters:
+          - lll
+        path: api/*
+      - linters:
+          - dupl
+          - lll
+        path: internal/*
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

internal/controller/metalstackcluster_controller_test.go

@@ -70,7 +70,7 @@ var _ = Describe("MetalStackCluster Controller", func() {
 
 	Context("without owning cluster resource", func() {
 		BeforeEach(func() {
-			resource.ObjectMeta.OwnerReferences = nil
+			resource.OwnerReferences = nil
 		})
 
 		It("should skip reconciles", func() {

test/utils/utils.go

@@ -24,7 +24,7 @@ import (
 	"os/exec"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2" //nolint:golint,revive
+	. "github.com/onsi/ginkgo/v2" //nolint:golint,staticcheck
 )
 
 const (
@@ -197,7 +197,7 @@ func GetProjectDir() (string, error) {
 	if err != nil {
 		return wd, err
 	}
-	wd = strings.Replace(wd, "/test/e2e", "", -1)
+	wd = strings.ReplaceAll(wd, "/test/e2e", "")
 	return wd, nil
 }