Ensure HMAC is not empty (#42)

robertvolkmann · web-flow · commit 54184d7a4737 · 2025-01-22T13:43:43.000+01:00
diff --git a/cmd/main.go b/cmd/main.go
@@ -36,11 +36,12 @@ import (
 	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
 
+	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
+
 	infrastructurev1alpha1 "github.com/metal-stack/cluster-api-provider-metal-stack/api/v1alpha1"
 	"github.com/metal-stack/cluster-api-provider-metal-stack/internal/controller"
 	fcmv2 "github.com/metal-stack/firewall-controller-manager/api/v2"
 	metalgo "github.com/metal-stack/metal-go"
-	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
 	// +kubebuilder:scaffold:imports
 )
 
@@ -197,7 +198,7 @@ func newMetalClient() (metalgo.Client, error) {
 	}
 
 	hmac := os.Getenv("METAL_API_HMAC")
-	if url == "" {
+	if hmac == "" {
 		return nil, errors.New("METAL_API_HMAC environment variable must be set")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -36,11 +36,12 @@ import (`
`36`	`36`	`metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"`
`37`	`37`	`"sigs.k8s.io/controller-runtime/pkg/webhook"`
`38`	`38`
	`39`	`+ clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"`
	`40`	`+`
`39`	`41`	`infrastructurev1alpha1 "github.com/metal-stack/cluster-api-provider-metal-stack/api/v1alpha1"`
`40`	`42`	`"github.com/metal-stack/cluster-api-provider-metal-stack/internal/controller"`
`41`	`43`	`fcmv2 "github.com/metal-stack/firewall-controller-manager/api/v2"`
`42`	`44`	`metalgo "github.com/metal-stack/metal-go"`
`43`		`- clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"`
`44`	`45`	`// +kubebuilder:scaffold:imports`
`45`	`46`	`)`
`46`	`47`
`@@ -197,7 +198,7 @@ func newMetalClient() (metalgo.Client, error) {`
`197`	`198`	`}`
`198`	`199`
`199`	`200`	`hmac := os.Getenv("METAL_API_HMAC")`
`200`		`- if url == "" {`
	`201`	`+ if hmac == "" {`
`201`	`202`	`return nil, errors.New("METAL_API_HMAC environment variable must be set")`
`202`	`203`	`}`
`203`	`204`