fix(fw): crds for status and tests

Author: vknabel

api/v1alpha1/metalstackfirewalldeployment_types.go

@@ -70,7 +70,7 @@ type MetalStackFirewallDeployment struct {
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
 	Spec   MetalStackFirewallDeploymentSpec   `json:"spec,omitzero"`
-	Status MetalStackFirewallDeploymentStatus `json:"status,omitzero"`
+	Status MetalStackFirewallDeploymentStatus `json:"status,omitempty"`
 }
 
 // +kubebuilder:object:root=true

config/crd/bases/infrastructure.cluster.x-k8s.io_metalstackfirewalldeployments.yaml

@@ -156,7 +156,6 @@ spec:
             type: object
         required:
         - spec
-        - status
         type: object
     served: true
     storage: true

test/e2e/frmwrk/shared_cluster.go

@@ -61,7 +61,6 @@ type E2ECluster struct {
 type E2EClusterRefs struct {
 	Namespace      *corev1.Namespace
 	NodeNetwork    *metalmodels.V1NetworkResponse
-	Firewall       *metalmodels.V1FirewallResponse
 	ControlPlaneIP *metalmodels.V1IPResponse
 
 	Workload framework.ClusterProxy
@@ -214,7 +213,6 @@ func (e2e *E2ECluster) GenerateAndApplyClusterTemplate(ctx context.Context) {
 
 	Expect(e2e.Refs.Namespace).NotTo(BeNil(), "namespace not created yet")
 	Expect(e2e.Refs.NodeNetwork).NotTo(BeNil(), "node network not created yet")
-	Expect(e2e.Refs.Firewall).NotTo(BeNil(), "firewall not created yet")
 
 	workloadTempl := clusterctl.ConfigCluster(ctx, clusterctl.ConfigClusterInput{
 		Namespace:                e2e.NamespaceName,