Skip to content

Commit 2b74fce

Browse files
authored
Migrate away from deprecated wrappers (#81)
1 parent b1186c6 commit 2b74fce

33 files changed

+842
-1049
lines changed

.github/workflows/docker.yaml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,16 @@ jobs:
3838
cache: false
3939

4040
- name: Lint
41-
uses: golangci/golangci-lint-action@v6
41+
uses: golangci/golangci-lint-action@v7
4242
with:
43-
args: --build-tags integration -p bugs -p unused -D protogetter --timeout=10m
43+
args: --build-tags integration -D protogetter --timeout=10m
4444

45-
- name: Make tag
46-
run: |
47-
[ "${GITHUB_EVENT_NAME}" == 'pull_request' ] && echo "tag=${GITHUB_HEAD_REF##*/}" >> $GITHUB_ENV || true
48-
[ "${GITHUB_EVENT_NAME}" == 'release' ] && echo "tag=${GITHUB_REF##*/}" >> $GITHUB_ENV || true
49-
[ "${GITHUB_EVENT_NAME}" == 'push' ] && echo "tag=latest" >> $GITHUB_ENV || true
45+
- name: Docker meta
46+
id: meta
47+
uses: docker/metadata-action@v5
48+
with:
49+
images: |
50+
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
5051
5152
- name: Build and Test
5253
run: |
@@ -63,4 +64,4 @@ jobs:
6364
context: .
6465
push: true
6566
sbom: true
66-
tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.tag }}
67+
tags: ${{ steps.meta.outputs.tags }}

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
FROM alpine:3.21 as health-downloader
2-
ENV GRPC_HEALTH_PROBE_VERSION=v0.4.37 \
1+
FROM alpine:3.22 AS health-downloader
2+
ENV GRPC_HEALTH_PROBE_VERSION=v0.4.39 \
33
GRPC_HEALTH_PROBE_URL=https://github.com/grpc-ecosystem/grpc-health-probe/releases/download
44
RUN apk -U add curl \
55
&& curl -fLso /bin/grpc_health_probe \

api/rest/mapper/mapper.go

Lines changed: 11 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import (
66
v1 "github.com/metal-stack/masterdata-api/api/rest/v1"
77
mdmv1 "github.com/metal-stack/masterdata-api/api/v1"
88
"google.golang.org/protobuf/types/known/timestamppb"
9-
"google.golang.org/protobuf/types/known/wrapperspb"
109
)
1110

1211
func ToMdmV1Tenant(t *v1.Tenant) *mdmv1.Tenant {
@@ -145,14 +144,9 @@ func ToMdmV1Quota(q *v1.Quota) *mdmv1.Quota {
145144
if q == nil {
146145
return nil
147146
}
148-
if q.Quota == nil {
149-
return nil
150-
}
151147

152148
return &mdmv1.Quota{
153-
Quota: &wrapperspb.Int32Value{
154-
Value: *q.Quota,
155-
},
149+
Max: q.Quota,
156150
}
157151
}
158152

@@ -178,18 +172,11 @@ func ToMdmV1ProjectFindRequest(r *v1.ProjectFindRequest) *mdmv1.ProjectFindReque
178172
return nil
179173
}
180174

181-
mdmv1r := new(mdmv1.ProjectFindRequest)
182-
if r.Id != nil {
183-
mdmv1r.Id = &wrapperspb.StringValue{Value: *r.Id}
184-
}
185-
if r.Description != nil {
186-
mdmv1r.Description = &wrapperspb.StringValue{Value: *r.Description}
187-
}
188-
if r.Name != nil {
189-
mdmv1r.Name = &wrapperspb.StringValue{Value: *r.Name}
190-
}
191-
if r.TenantId != nil {
192-
mdmv1r.TenantId = &wrapperspb.StringValue{Value: *r.TenantId}
175+
mdmv1r := &mdmv1.ProjectFindRequest{
176+
Id: r.Id,
177+
Name: r.Name,
178+
Description: r.Description,
179+
TenantId: r.TenantId,
193180
}
194181

195182
return mdmv1r
@@ -200,12 +187,9 @@ func ToMdmV1TenantFindRequest(r *v1.TenantFindRequest) *mdmv1.TenantFindRequest
200187
return nil
201188
}
202189

203-
mdmv1r := new(mdmv1.TenantFindRequest)
204-
if r.Id != nil {
205-
mdmv1r.Id = &wrapperspb.StringValue{Value: *r.Id}
206-
}
207-
if r.Name != nil {
208-
mdmv1r.Name = &wrapperspb.StringValue{Value: *r.Name}
190+
mdmv1r := &mdmv1.TenantFindRequest{
191+
Id: r.Id,
192+
Name: r.Name,
209193
}
210194
if r.Paging != nil {
211195
mdmv1r.Paging = &mdmv1.Paging{
@@ -253,17 +237,11 @@ func ToV1Quota(q *mdmv1.Quota) *v1.Quota {
253237
if q == nil {
254238
return nil
255239
}
240+
256241
return &v1.Quota{
257-
Quota: unwrapInt32(q.Quota),
242+
Quota: q.Max,
258243
}
259244
}
260-
func unwrapInt32(w *wrapperspb.Int32Value) *int32 {
261-
if w == nil {
262-
return nil
263-
}
264-
265-
return &w.Value
266-
}
267245

268246
func mustTimestampToTime(ts *timestamppb.Timestamp) *time.Time {
269247
if ts == nil {

api/v1/common.pb.go

Lines changed: 10 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)