Migrate to golangci-lint v2 (#616)

Author: majst01

.github/workflows/docker.yaml

@@ -38,9 +38,9 @@ jobs:
         cache: false
 
     - name: Lint
-      uses: golangci/golangci-lint-action@v6
+      uses: golangci/golangci-lint-action@v7
       with:
-        args: --build-tags integration -p bugs -p unused -D protogetter --timeout=5m
+        args: --build-tags integration -D protogetter --timeout=5m
 
     - name: Make tag
       run: |

.golangci.yaml

@@ -1,13 +1,33 @@
+version: "2"
 run:
   concurrency: 4
 linters:
+  enable:
+    - asciicheck
+    - bidichk
+    - gocheckcompilerdirectives
+    - testifylint
   disable:
+    - errcheck
+    - govet
     - musttag
     - protogetter
-  enable:
-    - testifylint
-    - unused
-  presets:
-    - bugs
-    - unused
-  fast: true
+    - staticcheck
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

cmd/metal-api/internal/datastore/integer_test.go

@@ -120,7 +120,7 @@ func TestRethinkStore_AcquireRandomUniqueInteger(t *testing.T) {
 
 	got, err := ip.AcquireRandomUniqueInteger()
 	require.NoError(t, err)
-	assert.EqualValues(t, rs.VRFPoolRangeMin, got)
+	assert.Equal(t, rs.VRFPoolRangeMin, got)
 
 	mock.AssertExpectations(t)
 }
@@ -164,7 +164,7 @@ func TestRethinkStore_AcquireUniqueInteger(t *testing.T) {
 				require.EqualError(t, err, tt.err.Error())
 			} else {
 				require.NoError(t, err)
-				assert.EqualValues(t, tt.value, got)
+				assert.Equal(t, tt.value, got)
 			}
 
 			if tt.requiresMock {
@@ -238,7 +238,7 @@ func TestRethinkStore_genericAcquire(t *testing.T) {
 				require.EqualError(t, err, tt.expectedErr.Error())
 			} else {
 				require.NoError(t, err)
-				assert.EqualValues(t, tt.value, got)
+				assert.Equal(t, tt.value, got)
 			}
 
 			if tt.requiresMock {

cmd/metal-api/internal/service/machine-service_test.go

@@ -295,8 +295,8 @@ func TestSetMachineStateIssuerResetWhenAvailable(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, "1", result.ID)
 	require.Equal(t, string(metal.AvailableState), result.State.Value)
-	require.Equal(t, "", result.State.Description)
-	require.Equal(t, "", result.State.Issuer)
+	require.Empty(t, result.State.Description)
+	require.Empty(t, result.State.Issuer)
 }
 
 func TestGetMachine(t *testing.T) {

cmd/metal-api/internal/service/size-service_test.go

@@ -75,7 +75,7 @@ func TestGetSize(t *testing.T) {
 	require.Equal(t, testdata.Sz1.ID, result.ID)
 	require.Equal(t, testdata.Sz1.Name, *result.Name)
 	require.Equal(t, testdata.Sz1.Description, *result.Description)
-	require.Equal(t, len(testdata.Sz1.Constraints), len(result.SizeConstraints))
+	require.Len(t, testdata.Sz1.Constraints, len(result.SizeConstraints))
 }
 
 func TestSuggest(t *testing.T) {