check version before adding sag configuration

Author: iljarotar

configdb/configdb.go

@@ -66,6 +66,11 @@ func GenerateConfigDB(input *values.Values, platform *p.Platform, environment *p
 	rules, tables := getACLRulesAndTables(input.SSHSourceranges)
 	vxlanevpn, vxlanTunnel, vxlanTunnelMap := getVXLAN(input.VTEP, input.LoopbackAddress)
 
+	sag, err := getSAG(input.SAG, version)
+	if err != nil {
+		return nil, err
+	}
+
 	configdb := ConfigDB{
 		ACLRules:          rules,
 		ACLTables:         tables,
@@ -98,7 +103,7 @@ func GenerateConfigDB(input *values.Values, platform *p.Platform, environment *p
 		Ports:              ports,
 		PortChannels:       getPortChannels(input.PortChannels),
 		PortChannelMembers: getPortChannelMembers(input.PortChannels.List),
-		SAG:                getSAG(input.SAG),
+		SAG:                sag,
 		VLANs:              getVLANs(input.VLANs),
 		VLANInterfaces:     getVLANInterfaces(input.VLANs),
 		VLANMembers:        getVLANMembers(input.VLANs),
@@ -487,16 +492,20 @@ func getPortsAndBreakouts(ports values.Ports, breakouts map[string]string, platf
 	return configPorts, configBreakouts, nil
 }
 
-func getSAG(sag values.SAG) *SAG {
+func getSAG(sag values.SAG, version *v.Version) (*SAG, error) {
+	if version.Branch != string(v.Branch202211) {
+		return nil, fmt.Errorf("sag configuration only works with sonic versions from the ec202211 branch")
+	}
+
 	if sag.MAC == "" {
-		return nil
+		return nil, nil
 	}
 
 	return &SAG{
 		SAGGlobal: SAGGlobal{
 			GatewayMAC: sag.MAC,
 		},
-	}
+	}, nil
 }
 
 func getVLANs(vlans []values.VLAN) map[string]VLAN {

configdb/configdb_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/metal-stack/metal-lib/pkg/testcommon"
 	p "github.com/metal-stack/sonic-configdb-utils/platform"
 	"github.com/metal-stack/sonic-configdb-utils/values"
+	v "github.com/metal-stack/sonic-configdb-utils/version"
 )
 
 func Test_getInterfaces(t *testing.T) {
@@ -551,3 +552,62 @@ func Test_getVRFs(t *testing.T) {
 		})
 	}
 }
+
+func Test_getSAG(t *testing.T) {
+	tests := []struct {
+		name    string
+		sag     values.SAG
+		version *v.Version
+		want    *SAG
+		wantErr bool
+	}{
+		{
+			name: "wrong version",
+			sag: values.SAG{
+				MAC: "11:11:11:11:11:11",
+			},
+			version: &v.Version{
+				Branch: string(v.Branch202111),
+			},
+			want:    nil,
+			wantErr: true,
+		},
+		{
+			name: "empty mac",
+			sag:  values.SAG{},
+			version: &v.Version{
+				Branch: string(v.Branch202211),
+			},
+			want:    nil,
+			wantErr: false,
+		},
+		{
+			name: "valid",
+			sag: values.SAG{
+				MAC: "11:11:11:11:11:11",
+			},
+			version: &v.Version{
+				Branch: string(v.Branch202211),
+			},
+			want: &SAG{
+				SAGGlobal: SAGGlobal{
+					GatewayMAC: "11:11:11:11:11:11",
+				},
+			},
+			wantErr: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := getSAG(tt.sag, tt.version)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("getSAG() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if diff := cmp.Diff(tt.want, got); diff != "" {
+				t.Errorf("getSAG() diff = %s", diff)
+			}
+		})
+	}
+}