e2e: new test on external inspection without annotations

With HardwareData CR, we don't actually need to use annotations to
populate the hardware details. And with new InspectionMode, we don't
need the disabled annotation either.

Let's test the behavior to be able to document it.

Signed-off-by: Dmitry Tantsur <[email protected]>

Author: dtantsur

test/e2e/external_inspection_test.go

@@ -249,6 +249,79 @@ var _ = Describe("External Inspection", Label("required", "external-inspection")
 		}, e2eConfig.GetIntervals(specName, "wait-bmh-deleted")...)
 	})
 
+	It("should skip inspection and become available when HardwareData exists and BMH has inspection disabled", func() {
+		By("Creating a secret with BMH credentials")
+		bmcCredentialsData := map[string]string{
+			"username": bmc.User,
+			"password": bmc.Password,
+		}
+		CreateSecret(ctx, clusterProxy.GetClient(), namespace.Name, secretName, bmcCredentialsData)
+
+		By("pre-creating a hardware data")
+		hwdata := metal3api.HardwareData{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      specName + "-inspect",
+				Namespace: namespace.Name,
+			},
+			Spec: metal3api.HardwareDataSpec{
+				HardwareDetails: &metal3api.HardwareDetails{},
+			},
+		}
+		err := json.Unmarshal([]byte(hardwareDetails), hwdata.Spec.HardwareDetails)
+		Expect(err).NotTo(HaveOccurred())
+		err = clusterProxy.GetClient().Create(ctx, &hwdata)
+		Expect(err).NotTo(HaveOccurred())
+
+		By("creating a BMH with inspection disabled and hardware details added")
+		bmh := metal3api.BareMetalHost{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      specName + "-inspect",
+				Namespace: namespace.Name,
+			},
+			Spec: metal3api.BareMetalHostSpec{
+				BMC: metal3api.BMCDetails{
+					Address:                        bmc.Address,
+					CredentialsName:                "bmc-credentials",
+					DisableCertificateVerification: bmc.DisableCertificateVerification,
+				},
+				BootMode:       metal3api.Legacy,
+				BootMACAddress: bmc.BootMacAddress,
+				InspectionMode: metal3api.InspectionModeDisabled,
+			},
+		}
+		err = clusterProxy.GetClient().Create(ctx, &bmh)
+		Expect(err).NotTo(HaveOccurred())
+
+		By("waiting for the BMH to become available")
+		WaitForBmhInProvisioningState(ctx, WaitForBmhInProvisioningStateInput{
+			Client:          clusterProxy.GetClient(),
+			Bmh:             bmh,
+			State:           metal3api.StateAvailable,
+			UndesiredStates: []metal3api.ProvisioningState{metal3api.StateInspecting},
+		}, e2eConfig.GetIntervals(specName, "wait-available")...)
+
+		By("checking that the BMH was not inspected")
+		key := types.NamespacedName{Namespace: bmh.Namespace, Name: bmh.Name}
+		Expect(clusterProxy.GetClient().Get(ctx, key, &bmh)).To(Succeed())
+		Expect(bmh.Status.OperationHistory.Inspect.Start.IsZero()).To(BeTrue())
+
+		By("checking that the hardware details match what was in hardware data")
+		hwStatusJSON, err := json.Marshal(bmh.Status.HardwareDetails)
+		Expect(err).NotTo(HaveOccurred())
+		Expect(hwStatusJSON).To(MatchJSON(hardwareDetails))
+
+		By("Delete BMH")
+		err = clusterProxy.GetClient().Delete(ctx, &bmh)
+		Expect(err).NotTo(HaveOccurred())
+
+		By("Waiting for the BMH to be deleted")
+		WaitForBmhDeleted(ctx, WaitForBmhDeletedInput{
+			Client:    clusterProxy.GetClient(),
+			BmhName:   bmh.Name,
+			Namespace: bmh.Namespace,
+		}, e2eConfig.GetIntervals(specName, "wait-bmh-deleted")...)
+	})
+
 	AfterEach(func() {
 		DumpResources(ctx, e2eConfig, clusterProxy, path.Join(artifactFolder, specName))
 		if !skipCleanup {