Merge pull request #2717 from dtantsur/prov-result

🌱 Do not use os.Exit outside of cmd

Author: metal3-io-bot

main.go

@@ -288,7 +288,11 @@ func main() {
 		provisionerFactory = &demo.Demo{}
 	} else {
 		provLog := zap.New(zap.UseFlagOptions(&logOpts)).WithName("provisioner")
-		provisionerFactory = ironic.NewProvisionerFactory(provLog, preprovImgEnable)
+		provisionerFactory, err = ironic.NewProvisionerFactory(provLog, preprovImgEnable)
+		if err != nil {
+			setupLog.Error(err, "cannot start ironic provisioner")
+			os.Exit(1)
+		}
 	}
 
 	maxConcurrency, err := getMaxConcurrentReconciles(controllerConcurrency)

pkg/provisioner/ironic/factory.go

@@ -24,17 +24,13 @@ type ironicProvisionerFactory struct {
 	clientIronic *gophercloud.ServiceClient
 }
 
-func NewProvisionerFactory(logger logr.Logger, havePreprovImgBuilder bool) provisioner.Factory {
+func NewProvisionerFactory(logger logr.Logger, havePreprovImgBuilder bool) (provisioner.Factory, error) {
 	factory := ironicProvisionerFactory{
 		log: logger.WithName("ironic"),
 	}
 
 	err := factory.init(havePreprovImgBuilder)
-	if err != nil {
-		factory.log.Error(err, "Cannot start ironic provisioner")
-		os.Exit(1)
-	}
-	return factory
+	return factory, err
 }
 
 func (f *ironicProvisionerFactory) init(havePreprovImgBuilder bool) error {