Merge pull request #2365 from Nordix/lentzi90/vbmctl-pool

🌱 VBMCTL: Avoid re-using the default storage pool

Author: metal3-io-bot

hack/clean-e2e.sh

@@ -21,6 +21,6 @@ virsh -c qemu:///system net-undefine baremetal-e2e
 rm -rf /tmp/pool_oo/*
 
 # Clean volume pool
-virsh pool-destroy default || true
-virsh pool-delete default || true
-virsh pool-undefine default || true
+virsh -c qemu:///system pool-destroy baremetal-e2e || true
+virsh -c qemu:///system pool-delete baremetal-e2e || true
+virsh -c qemu:///system pool-undefine baremetal-e2e || true

test/e2e/sushy-tools/sushy-emulator.conf

@@ -23,6 +23,8 @@ SUSHY_EMULATOR_LIBVIRT_URI = u'qemu:///system'
 # your VM has a floppy drive.
 SUSHY_EMULATOR_IGNORE_BOOT_DEVICE = False
 
+SUSHY_EMULATOR_STORAGE_POOL = 'baremetal-e2e'
+
 # The map of firmware loaders dependant on the boot mode and
 # system architecture. Ideally the x86_64 loader will be capable
 # of secure boot or not based on the chosen nvram.

test/vbmctl/main.go

@@ -135,13 +135,13 @@ func CreateVolume(conn *libvirt.Connect, volumeName, poolName, poolPath string,
 
 // CreateLibvirtVM creates a new virtual machine with the given name,
 // network name, and MAC address. It first creates a qcow2 file with a size
-// of 3GB and defines it in the default storage pool. The function then connects
+// of 3GB and defines it in the baremetal-e2e storage pool. The function then connects
 // to the libvirt daemon and uses a template to generate the VM's XML configuration.
 // If the domain is successfully defined and created, the virtual machine is
 // started. Errors during qcow2 file creation, volume creation, libvirt connection,
 // template rendering, or domain creation are returned.
 func CreateLibvirtVM(conn *libvirt.Connect, name, networkName, macAddress string) error {
-	poolName := "default"
+	poolName := "baremetal-e2e"
 	poolPath := "/tmp/pool_oo"
 
 	if err := CreateVolume(conn, name+"-1", poolName, poolPath, 20); err != nil { //nolint: mnd