e2e: add logLevel tests for MetalLB core components

- Add tests to verify logLevel default and debug
- Update Webhook error message for bgpBackend type

Signed-off-by: Anvesh J <[email protected]>

Author: ajaggapa

api/v1beta1/metallb_webhook.go

@@ -114,7 +114,7 @@ func (metallb *MetalLB) Validate() error {
 		metallb.Spec.BGPBackend != FRRK8sMode &&
 		metallb.Spec.BGPBackend != FRRK8sExternalMode &&
 		metallb.Spec.BGPBackend != FRRMode {
-		return errors.New("Invalid BGP Backend, must be one of native, frr, frr-k8s")
+		return errors.New("Invalid BGP Backend, must be one of native, frr, frr-k8s, frr-k8s-external")
 	}
 
 	if err := validateFRRK8sConfig(metallb.Spec); err != nil {

test/e2e/functional/tests/e2e.go

@@ -3,6 +3,7 @@ package tests
 import (
 	"context"
 	"fmt"
+	"io"
 	"os"
 	"time"
 
@@ -803,6 +804,125 @@ var _ = Describe("metallb", func() {
 			Expect(testclient.Client.Create(context.Background(), metallb)).Should(Succeed())
 		})
 	})
+
+	Context("MetalLB Core Components Log Level Feature", func() {
+		BeforeEach(func() {
+			metallbutils.DeleteDefaultMetalLB(OperatorNameSpace, UseMetallbResourcesFromFile)
+
+		})
+
+		AfterEach(func() {
+			metallbutils.DeleteDefaultMetalLB(OperatorNameSpace, UseMetallbResourcesFromFile)
+		})
+
+		It("Verify logLevel default and debug behavior in speaker and controller pods", func() {
+			// Create MetalLB with default log level (info)
+			metallb, err := metallbutils.Get(OperatorNameSpace, UseMetallbResourcesFromFile)
+			Expect(err).ToNot(HaveOccurred())
+			Expect(testclient.Client.Create(context.Background(), metallb)).Should(Succeed())
+
+			By("Waiting for MetalLB controller deployment to be ready")
+			metallbutils.WaitForControllerDeploymentReady(metallb.Namespace, metallbutils.DeployTimeout)
+
+			By("Waiting for MetalLB speaker daemonset to be ready")
+			metallbutils.WaitForSpeakerDaemonSetReady(metallb.Namespace, metallbutils.DeployTimeout)
+
+			By("Fetch controller pods from metallb-system namespace")
+			controllerPods := metallbutils.GetMetalLBPods(OperatorNameSpace, "controller")
+
+			By("Verify default loglevel in controller pod logs - should contain info but not debug")
+			for _, controllerPod := range controllerPods.Items {
+				req := testclient.Client.Pods(OperatorNameSpace).GetLogs(controllerPod.Name, &corev1.PodLogOptions{
+					Container: "controller",
+				})
+				logs, err := req.Stream(context.Background())
+				Expect(err).ToNot(HaveOccurred(), "Failed to get controller pod logs")
+				defer logs.Close()
+
+				logContent, err := io.ReadAll(logs)
+				Expect(err).ToNot(HaveOccurred(), "Failed to read controller pod logs")
+				logString := string(logContent)
+
+				Expect(logString).Should(ContainSubstring(`"level":"info"`), "Controller pod logs should contain info level logs by default")
+				Expect(logString).ShouldNot(ContainSubstring(`"level":"debug"`), "Controller pod logs should not contain debug level logs when using default info log level")
+			}
+
+			By("Fetch speaker pods from metallb-system namespace")
+			speakerPods := metallbutils.GetMetalLBPods(OperatorNameSpace, "speaker")
+
+			By("Verify default loglevel in speaker pod logs - should contain info but not debug")
+			for _, speakerPod := range speakerPods.Items {
+				req := testclient.Client.Pods(OperatorNameSpace).GetLogs(speakerPod.Name, &corev1.PodLogOptions{
+					Container: "speaker",
+				})
+				logs, err := req.Stream(context.Background())
+				Expect(err).ToNot(HaveOccurred(), "Failed to get speaker pod logs")
+				defer logs.Close()
+
+				logContent, err := io.ReadAll(logs)
+				Expect(err).ToNot(HaveOccurred(), "Failed to read speaker pod logs")
+				logString := string(logContent)
+
+				Expect(logString).Should(ContainSubstring(`"level":"info"`), "Speaker pod logs should contain info level logs by default")
+				Expect(logString).ShouldNot(ContainSubstring(`"level":"debug"`), "Speaker pod logs should not contain debug level logs when using default info log level")
+			}
+
+			// Update MetalLB CR to set LogLevel to debug
+			By("Updating MetalLB CR to set LogLevel to debug")
+			err = testclient.Client.Get(context.Background(), goclient.ObjectKey{Namespace: metallb.Namespace, Name: metallb.Name}, metallb)
+			Expect(err).ToNot(HaveOccurred())
+			metallb.Spec.LogLevel = metallbv1beta1.LogLevelDebug
+			Expect(testclient.Client.Update(context.Background(), metallb)).Should(Succeed())
+
+			By("Waiting for Progressing condition to be True after update")
+			metallbutils.WaitForProgressingConditionTrue(metallb, 30*time.Second)
+
+			By("Waiting for Progressing condition to be False and Available condition to be True")
+			metallbutils.WaitForProgressingFalseAndAvailableTrue(metallb, metallbutils.DeployTimeout)
+
+			By("Fetch controller pods after update")
+			controllerPods = metallbutils.GetMetalLBPods(OperatorNameSpace, "controller")
+
+			By("Verify debug loglevel in controller pod logs - should contain both debug and info")
+			for _, controllerPod := range controllerPods.Items {
+				req := testclient.Client.Pods(OperatorNameSpace).GetLogs(controllerPod.Name, &corev1.PodLogOptions{
+					Container: "controller",
+				})
+				logs, err := req.Stream(context.Background())
+				Expect(err).ToNot(HaveOccurred(), "Failed to get controller pod logs")
+				defer logs.Close()
+
+				logContent, err := io.ReadAll(logs)
+				Expect(err).ToNot(HaveOccurred(), "Failed to read controller pod logs")
+				logString := string(logContent)
+
+				// Verify that debug log level is set - logs should contain JSON format "level":"debug"
+				Expect(logString).Should(ContainSubstring(`"level":"debug"`), "Controller pod logs should contain debug level logs when LogLevel is set to debug")
+				Expect(logString).Should(ContainSubstring(`"level":"info"`), "Controller pod logs should also contain info level logs when LogLevel is set to debug")
+			}
+
+			By("Fetch speaker pods after update")
+			speakerPods = metallbutils.GetMetalLBPods(OperatorNameSpace, "speaker")
+
+			By("Verify debug loglevel in speaker pod logs - should contain both debug and info")
+			for _, speakerPod := range speakerPods.Items {
+				req := testclient.Client.Pods(OperatorNameSpace).GetLogs(speakerPod.Name, &corev1.PodLogOptions{
+					Container: "speaker",
+				})
+				logs, err := req.Stream(context.Background())
+				Expect(err).ToNot(HaveOccurred(), "Failed to get speaker pod logs")
+				defer logs.Close()
+
+				logContent, err := io.ReadAll(logs)
+				Expect(err).ToNot(HaveOccurred(), "Failed to read speaker pod logs")
+				logString := string(logContent)
+
+				// Verify that debug log level is set - logs should contain JSON format "level":"debug"
+				Expect(logString).Should(ContainSubstring(`"level":"debug"`), "Speaker pod logs should contain debug level logs when LogLevel is set to debug")
+				Expect(logString).Should(ContainSubstring(`"level":"info"`), "Speaker pod logs should also contain info level logs when LogLevel is set to debug")
+			}
+		})
+	})
 })
 
 // Gomega transformation functions for v1.Container

test/e2e/metallb/metallb.go

@@ -13,6 +13,7 @@ import (
 	"github.com/metallb/metallb-operator/pkg/status"
 	"github.com/metallb/metallb-operator/test/consts"
 	testclient "github.com/metallb/metallb-operator/test/e2e/client"
+	v1 "k8s.io/api/core/v1"
 	schv1 "k8s.io/api/scheduling/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -142,3 +143,100 @@ func DeletePriorityClass(pc *schv1.PriorityClass) {
 	}
 	Expect(err).ToNot(HaveOccurred())
 }
+
+// WaitForControllerDeploymentReady waits for the MetalLB controller deployment to be ready
+func WaitForControllerDeploymentReady(namespace string, timeout time.Duration) {
+	Eventually(func() error {
+		deploy, err := testclient.Client.Deployments(namespace).Get(context.Background(), consts.MetalLBDeploymentName, metav1.GetOptions{})
+		if err != nil {
+			return err
+		}
+
+		if deploy.Status.ReadyReplicas != deploy.Status.Replicas {
+			return fmt.Errorf("deployment %s is not ready, expected %d ready replicas got %d", consts.MetalLBDeploymentName, deploy.Status.Replicas, deploy.Status.ReadyReplicas)
+		}
+
+		return nil
+	}, timeout, Interval).ShouldNot(HaveOccurred())
+}
+
+// WaitForSpeakerDaemonSetReady waits for the MetalLB speaker daemonset to be ready
+func WaitForSpeakerDaemonSetReady(namespace string, timeout time.Duration) {
+	Eventually(func() error {
+		daemonset, err := testclient.Client.DaemonSets(namespace).Get(context.Background(), consts.MetalLBDaemonsetName, metav1.GetOptions{})
+		if err != nil {
+			return err
+		}
+
+		if daemonset.Status.DesiredNumberScheduled == 0 {
+			return fmt.Errorf("daemonset %s has no desired pods scheduled", consts.MetalLBDaemonsetName)
+		}
+		if daemonset.Status.DesiredNumberScheduled != daemonset.Status.NumberReady {
+			return fmt.Errorf("daemonset %s is not ready, expected %d ready pods got %d", consts.MetalLBDaemonsetName, daemonset.Status.DesiredNumberScheduled, daemonset.Status.NumberReady)
+		}
+
+		return nil
+	}, timeout, Interval).ShouldNot(HaveOccurred())
+}
+
+// WaitForProgressingConditionTrue waits for the MetalLB Progressing condition to be True
+func WaitForProgressingConditionTrue(metallb *metallbv1beta1.MetalLB, timeout time.Duration) {
+	Eventually(func() bool {
+		config := &metallbv1beta1.MetalLB{}
+		err := testclient.Client.Get(context.Background(), goclient.ObjectKey{Namespace: metallb.Namespace, Name: metallb.Name}, config)
+		if err != nil {
+			return false
+		}
+		if config.Status.Conditions == nil {
+			return false
+		}
+		for _, condition := range config.Status.Conditions {
+			if condition.Type == status.ConditionProgressing && condition.Status == metav1.ConditionTrue {
+				return true
+			}
+		}
+		return false
+	}, timeout, Interval).Should(BeTrue(), "Progressing condition should be True after update")
+}
+
+// WaitForProgressingFalseAndAvailableTrue waits for the MetalLB Progressing condition to be False and Available condition to be True
+func WaitForProgressingFalseAndAvailableTrue(metallb *metallbv1beta1.MetalLB, timeout time.Duration) {
+	Eventually(func() bool {
+		config := &metallbv1beta1.MetalLB{}
+		err := testclient.Client.Get(context.Background(), goclient.ObjectKey{Namespace: metallb.Namespace, Name: metallb.Name}, config)
+		if err != nil {
+			return false
+		}
+		if config.Status.Conditions == nil {
+			return false
+		}
+		progressingFalse := false
+		availableTrue := false
+		for _, condition := range config.Status.Conditions {
+			if condition.Type == status.ConditionProgressing && condition.Status == metav1.ConditionFalse {
+				progressingFalse = true
+			}
+			if condition.Type == status.ConditionAvailable && condition.Status == metav1.ConditionTrue {
+				availableTrue = true
+			}
+		}
+		return progressingFalse && availableTrue
+	}, timeout, Interval).Should(BeTrue(), "Progressing should be False and Available should be True after update completes")
+}
+
+func DeleteDefaultMetalLB(namespace string, useMetallbResourcesFromFile bool) {
+	metallb, err := Get(namespace, useMetallbResourcesFromFile)
+	Expect(err).ToNot(HaveOccurred(), "Failed to get MetalLB resource")
+	DeleteAndCheck(metallb)
+}
+
+// GetMetalLBPods fetches pods for a given MetalLB component (controller or speaker)
+// and validates that the list is not empty
+func GetMetalLBPods(namespace string, component string) *v1.PodList {
+	pods, err := testclient.Client.Pods(namespace).List(context.Background(), metav1.ListOptions{
+		LabelSelector: fmt.Sprintf("component=%s", component),
+	})
+	Expect(err).ToNot(HaveOccurred(), fmt.Sprintf("Failed to list %s pods", component))
+	Expect(len(pods.Items)).Should(BeNumerically(">", 0), fmt.Sprintf("%s Pods List should not be empty", component))
+	return pods
+}