-
Notifications
You must be signed in to change notification settings - Fork 100
Split ~ footex
#3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split ~ footex
#3275
Conversation
I conducted some tests on the new theorems, targeting the commands that would typically cause metamath-exe to get stuck. These are the time reports:
It's quite evident that the revision in this PR is a substantial improvement over the old state. Only note: |
Too bad I did not see your issues with ~footex earlier @GinoGiotto, if I had done that change earlier it would have spared you quite some computing power and time. I think ideally we should try to reproduce that case and keep it in a separated test/stress database, but I currently don't see how without pulling a substantial part of set.mm, or better identifying what made that proof so special. |
My initial intention with the second attempt was to produce a log file and report it as an issue (basically I wanted to see if metamath-exe writes something before crashing), but since it proceeded without interruptions I simply committed the shortened proof instead.
Temporarily it might be enough a simple TODO note, like "Delete and extract a test case once its time-draining nature has been examined". |
~ footexALT should be kept until the "problem" with metamath.exe is solved. It has a "(Proof modification is discouraged.)" tag, so a global minimization will not touch it, and I do not see a need to perform a global |
Splits
~ footex
into 3 parts. As mentioned in #3269, metamath-exe crashes when attempting to minimize~ footex
, although it is not a particularly long proof.I've kept the original version of
~ footex
as~ footexALT
, so that it can be used for better understanding the issue, experiments, and possibly stress tests. See #3271 for a discussion and investigation on~ footex
.Fixes #3271