fixes after review

- hide mode executors in modes/index.js
- fixed use strict regex
- break execution when not from console (e.g. load module by impress)

Author: samvimes01

metarhia-build.js

@@ -8,9 +8,7 @@ const {
   loadLicense,
   validateSourceFiles,
 } = require('./src/config/loader');
-const { executeLibMode } = require('./src/modes/lib-mode');
-const { executeIIFEMode } = require('./src/modes/iife-mode');
-const { executeAppMode } = require('./src/modes/app-mode');
+const { modeExecutors } = require('./src/modes');
 const logger = require('./src/utils/logger');
 
 const main = async () => {
@@ -34,25 +32,24 @@ const main = async () => {
     validateSourceFiles(config.order, config.libDir, cwd);
   }
 
-  const modeExecutors = {
-    lib: () => executeLibMode(config, packageJson, license),
-    iife: () => executeIIFEMode(config, packageJson, license),
-    app: () => executeAppMode(config),
-  };
-
   const executor = modeExecutors[config.mode];
   if (!executor) {
-    logger.error(`Unknown mode: ${config.mode}`);
-    process.exit(1);
+    throw new Error(`Unknown mode: ${config.mode}`);
   }
 
-  await executor();
+  await executor(config, packageJson, license);
 };
 
+if (!process.stdin.isTTY) {
+  // Running as a script file or input is redirected
+  // Do nothing
+  return;
+}
+
 main().catch((error) => {
   logger.error(`Build failed: ${error.message}`);
   if (error.stack) {
-    console.error(error.stack);
+    logger.error(error.stack);
   }
   process.exit(1);
 });

src/bundler/bundler.js

@@ -29,7 +29,7 @@ class Bundler {
     );
     let content = readFileSync(filePath, `processing ${filename}`);
 
-    content = content.replace(`'use strict';\n\n`, '');
+    content = content.replace(/'use strict';?\n{0,2}/g, '');
     content = processImports(content, filename, this.importRegistry);
 
     if (this.config.mode === 'iife') {

src/modes/index.js

@@ -0,0 +1,13 @@
+'use strict';
+
+const { executeLibMode } = require('./src/modes/lib-mode');
+const { executeIIFEMode } = require('./src/modes/iife-mode');
+const { executeAppMode } = require('./src/modes/app-mode');
+
+module.exports = {
+  modeExecutors: {
+    lib: executeLibMode,
+    iife: executeIIFEMode,
+    app: executeAppMode,
+  },
+};