Skip to content

Commit b329ccd

Browse files
metascroyfacebook-github-bot
authored andcommitted
Back out "Add extra logging in CoreML (pytorch#13890)" (pytorch#14353)
Summary: Original commit changeset: ae667b071853 Original Phabricator Diff: D81256207 Since the introduction of D80715432, WhatsApp is seeing an increase in model load failures with error code 0x23 (P1948468840). From logs, the underlying issue is something like "Model init failed “model.mlmodelc” couldn’t be moved to “models” because an item with the same name already exists." FB app has also seen an increase in error code 0x23 since 9/5. We are unable to reproduce this error locally, but out of caution we want to revert D80715432 and see if the errors resolve. Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Differential Revision: D82581442
1 parent b1a41e7 commit b329ccd

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

backends/apple/coreml/runtime/delegate/ETCoreMLModelManager.mm

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -449,14 +449,12 @@ - (nullable NSURL *)compiledModelURLWithIdentifier:(NSString *)identifier
449449
case ModelAssetType::CompiledModel: {
450450
// The model is already compiled; no further action needed.
451451
// Return the existing model URL.
452-
ETCoreMLLogInfo("The model in the pte file is pre-compiled. Skipping compilation.");
453452
return modelURL;
454453
}
455454

456455
case ModelAssetType::Model: {
457456
// The model is not compiled yet.
458457
// Compile the model at the specified URL with a maximum wait time of 5 minutes.
459-
ETCoreMLLogInfo("The model in the pte file is not pre-compiled. Compiling with a 5 min timeout.");
460458
NSURL *compiledModelURL = [ETCoreMLModelCompiler compileModelAtURL:modelURL
461459
maxWaitTimeInSeconds:(5 * 60)
462460
error:error];
@@ -492,7 +490,6 @@ - (nullable ETCoreMLAsset *)compiledModelAssetWithMetadata:(const ModelMetadata&
492490
error:error];
493491
if (compiledModelURL) {
494492
// Move the compiled model to the asset manager to transfer ownership.
495-
ETCoreMLLogInfo("Storing compiled asset with identifier=%@ in the asset manager.", identifier);
496493
compiledModelAsset = [self.assetManager storeAssetAtURL:compiledModelURL withIdentifier:identifier error:error];
497494
}
498495
}];

0 commit comments

Comments
 (0)