Skip to content

Commit 0f74c64

Browse files
HeadcrabedConchuOD
authored andcommitted
riscv: dts: starfive: Remove PMIC interrupt info for Visionfive 2 board
Interrupt line number of the AXP15060 PMIC is not a necessary part of its device tree. Originally the binding required one, so the dts patch added an invalid interrupt that the driver ignored (0) as the interrupt line of the PMIC is not actually connected on this platform. This went unnoticed during review as it would have been a valid interrupt for a GPIO controller, but it is not for the PLIC. The PLIC, on this platform at least, silently ignores the enablement of interrupt 0. Bo Gan is running a modified version of OpenSBI that faults if writes are done to reserved fields, so their kernel runs into problems. Delete the invalid interrupt from the device tree. Cc: [email protected] Reported-by: Bo Gan <[email protected]> Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Shengyu Qu <[email protected]> Fixes: 2378341 ("riscv: dts: starfive: Enable axp15060 pmic for cpufreq") [conor: rewrite the commit message to add more detail] Signed-off-by: Conor Dooley <[email protected]>
1 parent 4cece76 commit 0f74c64

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,6 @@
238238
axp15060: pmic@36 {
239239
compatible = "x-powers,axp15060";
240240
reg = <0x36>;
241-
interrupts = <0>;
242241
interrupt-controller;
243242
#interrupt-cells = <1>;
244243

0 commit comments

Comments
 (0)