Merge pull request #30 from metaversecloud-com/dev

Update SDK & fix breaking changes

Author: LinaBell

.github/CODEOWNERS

@@ -0,0 +1 @@
+* @cpsiaki @LinaBell @liebeskind

.github/workflows/aws_prod_release.yml

@@ -92,7 +92,7 @@ jobs:
 
       - name: Build and version tag
         run: |
-          docker build --build-arg REF=${{ github.ref}} --build-arg COMMIT_HASH=${{ github.sha}} -t ${{ steps.metadata.outputs.tags }} .
+          docker build --build-arg REF=${{ github.ref}} --build-arg COMMIT_HASH=$(git rev-parse --short ${{ github.sha }}) -t ${{ steps.metadata.outputs.tags }} .
           docker tag ${{ steps.metadata.outputs.tags }} ${{ steps.metadata-latest.outputs.tags }}
                         
       - name: push docker image to Amazon ECR

client/src/pages/QuestItemClicked.tsx

@@ -16,23 +16,28 @@ export const QuestItemClicked = () => {
 
   // context
   const { questDetails, hasInteractiveParams } = useContext(GlobalStateContext);
-  const { questItemImage } = questDetails
+  const { questItemImage } = questDetails;
 
   useEffect(() => {
     if (hasInteractiveParams) {
-      backendAPI.post("/quest-item-clicked")
+      backendAPI
+        .post("/quest-item-clicked")
         .then((result) => {
           const { addedClick, numberAllowedToCollect, totalCollectedToday, success } = result.data;
           if (addedClick) {
             setCollectedText(`${totalCollectedToday}/${numberAllowedToCollect} collected today`);
-            setMessage(`🎉 Congratulations! You are one step closer to completing your daily quest!`);
+            if (totalCollectedToday === numberAllowedToCollect) {
+              setMessage(`🎉 Congratulations! You have completed your daily quest!`);
+            } else {
+              setMessage(`🎉 Congratulations! You are one step closer to completing your daily quest!`);
+            }
           } else if (success) {
             setMessage(`🎉 You have already completed your daily quest! Come back tomorrow!`);
             setCollectedText(`${numberAllowedToCollect}/${numberAllowedToCollect} collected today`);
           }
         })
         .catch(() => console.error("Error collecting Quest item"))
-        .finally(() => setIsLoading(false))
+        .finally(() => setIsLoading(false));
     }
   }, [hasInteractiveParams]);
 
@@ -61,4 +66,4 @@ export const QuestItemClicked = () => {
   );
 };
 
-export default QuestItemClicked
+export default QuestItemClicked;

package-lock.json

@@ -15,7 +15,7 @@
   },
   "dependencies": {
     "@googleapis/sheets": "^7.0.0",
-    "@rtsdk/topia": "^0.12.0",
+    "@rtsdk/topia": "^0.15.4",
     "axios": "^1.6.8",
     "concurrently": "^8.2.2",
     "typescript": "^5.4.3",

package.json

@@ -18,6 +18,7 @@ export const handleDropQuestItem = async (req: Request, res: Response) => {
 
     const { dataObject, world } = await getWorldDetails(credentials, true);
     const { questItemImage } = dataObject as DataObjectType;
+    if (!questItemImage) throw "questItemImage is required";
 
     // Randomly place the quest item asset
     const position = getRandomCoordinates(world.width, world.height);

server/controllers/droppedAssets/handleDropQuestItem.ts

@@ -7,6 +7,8 @@ export const handleUpdateAdminSettings = async (req: Request, res: Response) =>
     const sceneDropId = credentials.sceneDropId || credentials.assetId;
     const { numberAllowedToCollect, questItemImage } = req.body;
 
+    if (!questItemImage) throw "questItemImage is required";
+
     const { world } = await getWorldDetails(credentials, false);
 
     const lockId = `${sceneDropId}-adminUpdates-${new Date(Math.round(new Date().getTime() / 10000) * 10000)}`;

server/controllers/handleUpdateAdminSettings.ts

@@ -21,7 +21,6 @@ const sheetsClient = sheets.sheets({ version: "v4", auth });
 
 export const addNewRowToGoogleSheets = async (SSAEvents: SSAEvent[]) => {
   try {
-    // Only execute this function if we have GOOGLESHEETS_SHEET_ID in the environment variables.
     if (!process.env.GOOGLESHEETS_SHEET_ID) return;
 
     const data = [];

server/utils/addNewRowToGoogleSheets.ts

@@ -28,7 +28,7 @@ export const errorHandler = ({
             reqQueryParams,
             reqBody: req?.body,
           },
-          error: JSON.stringify(error),
+          error: JSON.stringify(error, Object.getOwnPropertyNames(error)),
         }),
       );
     }