credentials bugfix

Author: LinaBell

server/controllers/handleCancelRace.js

@@ -3,6 +3,7 @@ import { errorHandler, getCredentials, World } from "../utils/index.js";
 export const handleCancelRace = async (req, res) => {
   try {
     const credentials = getCredentials(req.query);
+    const { urlSlug, profileId, sceneDropId } = credentials;
 
     const world = await World.create(urlSlug, { credentials });
 

server/utils/checkpoints/finishLineEntered.js

@@ -4,7 +4,7 @@ import { timeToValue } from "../utils.js";
 
 export const finishLineEntered = async ({ credentials, currentElapsedTime, profileObject, raceObject, world }) => {
   try {
-    const { profileId, sceneDropId, urlSlug, username, visitorId } = credentials;
+    const { profileId, sceneDropId, urlSlug, visitorId } = credentials;
     const { checkpoints, highscore } = profileObject;
     const allCheckpointsCompleted = raceObject.numberOfCheckpoints === Object.keys(checkpoints).length;
 
@@ -13,35 +13,31 @@ export const finishLineEntered = async ({ credentials, currentElapsedTime, profi
     const newHighscore =
       !highscore || timeToValue(currentElapsedTime) < timeToValue(highscore) ? currentElapsedTime : highscore;
 
+    await world.updateDataObject(
+      {
+        [`${sceneDropId}.profiles.${profileId}.checkpoints`]: {},
+        [`${sceneDropId}.profiles.${profileId}.elapsedTime`]: currentElapsedTime,
+        [`${sceneDropId}.profiles.${profileId}.startTimestamp`]: null,
+        [`${sceneDropId}.profiles.${profileId}.highscore`]: newHighscore,
+      },
+      { analytics: [{ analyticName: "completions", uniqueKey: profileId }] },
+    );
+
     if (newHighscore !== highscore) world.triggerActivity({ type: WorldActivityType.GAME_HIGH_SCORE, assetId });
 
     const visitor = await Visitor.get(visitorId, urlSlug, { credentials });
     const { x, y } = visitor.moveTo;
 
-    await Promise.all(
-      world.updateDataObject(
-        {
-          [`${sceneDropId}.profiles.${profileId}`]: {
-            checkpoints: {},
-            elapsedTime: currentElapsedTime,
-            highscore: newHighscore,
-            startTimestamp: null,
-            username,
-          },
-        },
-        { analytics: [{ analyticName: "completions", uniqueKey: profileId }] },
-      ),
-      visitor.fireToast({
-        groupId: "race",
-        title: "🏁 Finish",
-        text: `You finished the race! Your time: ${currentElapsedTime}`,
-      }),
-      visitor.triggerParticle({
-        name: "trophy_float",
-        duration: 3,
-        position: { x, y },
-      }),
-    );
+    visitor.fireToast({
+      groupId: "race",
+      title: "🏁 Finish",
+      text: `You finished the race! Your time: ${currentElapsedTime}`,
+    });
+    visitor.triggerParticle({
+      name: "trophy_float",
+      duration: 3,
+      position: { x, y },
+    });
 
     return;
   } catch (error) {