fix: Only remove implicit HEAD routes. (fastify#4596)

* fix: Only remove implicit HEAD routes.

* test: Added test.

* Update test/route.test.js

Co-authored-by: James Sumners <[email protected]>

---------

Co-authored-by: James Sumners <[email protected]>

Author: ShogunPanda

lib/route.js

@@ -303,7 +303,7 @@ function buildRouting (options) {
 
       // remove the head route created by fastify
       if (hasHEADHandler && !context[kRouteByFastify] && headHandler.store[kRouteByFastify]) {
-        router.off(opts.method, opts.url, { constraints })
+        router.off('HEAD', opts.url, { constraints })
       }
 
       try {

test/route.test.js

@@ -1493,3 +1493,17 @@ test('exposeHeadRoute should not reuse the same route option', async t => {
     }
   })
 })
+
+test('using fastify.all when a catchall is defined does not degrade performance', { timeout: 5000 }, async t => {
+  t.plan(1)
+
+  const fastify = Fastify()
+
+  fastify.get('/*', async (_, reply) => reply.json({ ok: true }))
+
+  for (let i = 0; i < 100; i++) {
+    fastify.all(`/${i}`, async (_, reply) => reply.json({ ok: true }))
+  }
+
+  t.pass()
+})