Fix crash when onReady hook throws (fastify#4579)

Signed-off-by: Matteo Collina <[email protected]>

Author: mcollina

lib/hooks.js

@@ -150,10 +150,14 @@ function hookRunnerApplication (hookName, boot, server, cb) {
         return
       }
 
-      const ret = fn.call(server)
-      if (ret && typeof ret.then === 'function') {
-        ret.then(done, done)
-        return
+      try {
+        const ret = fn.call(server)
+        if (ret && typeof ret.then === 'function') {
+          ret.then(done, done)
+          return
+        }
+      } catch (error) {
+        err = error
       }
 
       done(err) // auto done

test/hooks.on-ready.test.js

@@ -372,3 +372,16 @@ t.test('ready return registered', t => {
     .then(instance => { t.same(instance, fastify) })
     .catch(err => { t.fail(err) })
 })
+
+t.test('do not crash with error in follow up onReady hook', async t => {
+  const fastify = Fastify()
+
+  fastify.addHook('onReady', async function () {
+  })
+
+  fastify.addHook('onReady', function () {
+    throw new Error('kaboom')
+  })
+
+  await t.rejects(fastify.ready())
+})