Skip to content

Commit 3b5353a

Browse files
authored
fix(types): make RequestInit properties assignable (nodejs#1446)
1 parent 5478cdd commit 3b5353a

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

test/types/fetch.test-d.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ const responseInit: ResponseInit = { status: 200, statusText: 'OK' }
2929
const requestInit2: RequestInit = {
3030
dispatcher: new Agent()
3131
}
32+
const requestInit3: RequestInit = {}
33+
// Test assignment. See https://github.com/whatwg/fetch/issues/1445
34+
requestInit3.credentials = 'include'
3235

3336
declare const request: Request
3437
declare const headers: Headers

types/fetch.d.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -101,19 +101,19 @@ type RequestDestination =
101101
| 'xslt'
102102

103103
export interface RequestInit {
104-
readonly method?: string
105-
readonly keepalive?: boolean
106-
readonly headers?: HeadersInit
107-
readonly body?: BodyInit
108-
readonly redirect?: RequestRedirect
109-
readonly integrity?: string
110-
readonly signal?: AbortSignal
111-
readonly credentials?: RequestCredentials
112-
readonly mode?: RequestMode
113-
readonly referrer?: string
114-
readonly referrerPolicy?: ReferrerPolicy
115-
readonly window?: null
116-
readonly dispatcher?: Dispatcher
104+
method?: string
105+
keepalive?: boolean
106+
headers?: HeadersInit
107+
body?: BodyInit
108+
redirect?: RequestRedirect
109+
integrity?: string
110+
signal?: AbortSignal
111+
credentials?: RequestCredentials
112+
mode?: RequestMode
113+
referrer?: string
114+
referrerPolicy?: ReferrerPolicy
115+
window?: null
116+
dispatcher?: Dispatcher
117117
}
118118

119119
export type ReferrerPolicy =

0 commit comments

Comments
 (0)