Revert "fix: get set-cookie w/ credentials: include (nodejs#1454)"

This reverts commit 5a580ed.

Author: mcollina

lib/fetch/index.js

@@ -654,7 +654,7 @@ async function mainFetch (fetchParams, recursive = false) {
     // Set response to the following filtered response with response as its
     // internal response, depending on request’s response tainting:
     if (request.responseTainting === 'basic') {
-      response = filterResponse(response, 'basic', request.credentials)
+      response = filterResponse(response, 'basic')
     } else if (request.responseTainting === 'cors') {
       response = filterResponse(response, 'cors')
     } else if (request.responseTainting === 'opaque') {

lib/fetch/response.js

@@ -407,7 +407,7 @@ function makeFilteredHeadersList (headersList, filter) {
 }
 
 // https://fetch.spec.whatwg.org/#concept-filtered-response
-function filterResponse (response, type, credentials) {
+function filterResponse (response, type) {
   // Set response to the following filtered response with response as its
   // internal response, depending on request’s response tainting:
   if (type === 'basic') {
@@ -419,7 +419,7 @@ function filterResponse (response, type, credentials) {
       type: 'basic',
       headersList: makeFilteredHeadersList(
         response.headersList,
-        (name) => credentials === 'include' || !forbiddenResponseHeaderNames.includes(name.toLowerCase())
+        (name) => !forbiddenResponseHeaderNames.includes(name.toLowerCase())
       )
     })
   } else if (type === 'cors') {

test/fetch/client-fetch.js

@@ -403,21 +403,3 @@ test('custom agent node fetch', (t) => {
     t.strictSame(obj, await body.json())
   })
 })
-
-test('get set-cookie with credentials: include (#1262)', (t) => {
-  t.plan(1)
-
-  const server = createServer((req, res) => {
-    res.setHeader('set-cookie', 'hello=world')
-    res.end('Hello World!')
-  })
-  t.teardown(server.close.bind(server))
-
-  server.listen(0, async () => {
-    const { headers } = await fetch(`http://localhost:${server.address().port}`, {
-      credentials: 'include'
-    })
-
-    t.equal(headers.get('set-cookie'), 'hello=world')
-  })
-})