Skip to content

Commit 05f9508

Browse files
authored
Remove unused code (netty#761)
Motivation: We dont use quiche_header_info anymore. Let's remove it Modifications: Remove unused code Result: Cleanup
1 parent a393f49 commit 05f9508

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

codec-classes-quic/src/main/java/io/netty/incubator/codec/quic/Quiche.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -314,12 +314,6 @@ private static void loadNativeLibrary() {
314314
*/
315315
static native boolean quiche_version_is_supported(int version);
316316

317-
/**
318-
* See <a href="https://github.com/cloudflare/quiche/blob/0.6.0/include/quiche.h#L196">quiche_header_info</a>.
319-
*/
320-
static native int quiche_header_info(long bufAddr, int bufLength, int dcil, long versionAddr, long typeAddr,
321-
long scidAddr, long scidLenAddr, long dcidAddr, long dcidLenAddr,
322-
long tokenAddr, long tokenLenAddr);
323317
/**
324318
* See <a href="https://github.com/cloudflare/quiche/blob/0.6.0/include/quiche.h#L215">quiche_negotiate_version</a>.
325319
*/

codec-native-quic/src/main/c/netty_quic_quiche.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -366,15 +366,6 @@ static jboolean netty_quiche_conn_set_qlog_path(JNIEnv* env, jclass clazz, jlong
366366
return ret == true ? JNI_TRUE : JNI_FALSE;
367367
}
368368

369-
static jint netty_quiche_header_info(JNIEnv* env, jclass clazz, jlong buf, jint buf_len, jint dcil, jlong version,
370-
jlong type, jlong scid, jlong scid_len, jlong dcid, jlong dcid_len, jlong token, jlong token_len) {
371-
return (jint) quiche_header_info((const uint8_t *) buf, (size_t) buf_len, (size_t) dcil,
372-
(uint32_t *) version, (uint8_t *) type,
373-
(uint8_t *) scid, (size_t *) scid_len,
374-
(uint8_t *) dcid, (size_t *) dcid_len,
375-
(uint8_t *) token, (size_t *) token_len);
376-
}
377-
378369
static jint netty_quiche_negotiate_version(JNIEnv* env, jclass clazz, jlong scid, jint scid_len, jlong dcid, jint dcid_len, jlong out, jint out_len) {
379370
return (jint) quiche_negotiate_version((const uint8_t *) scid, (size_t) scid_len,
380371
(const uint8_t *) dcid, (size_t) dcid_len,
@@ -1172,7 +1163,6 @@ static const jint statically_referenced_fixed_method_table_size = sizeof(statica
11721163
static const JNINativeMethod fixed_method_table[] = {
11731164
{ "quiche_version", "()Ljava/lang/String;", (void *) netty_quiche_version },
11741165
{ "quiche_version_is_supported", "(I)Z", (void *) netty_quiche_version_is_supported },
1175-
{ "quiche_header_info", "(JIIJJJJJJJJ)I", (void *) netty_quiche_header_info },
11761166
{ "quiche_negotiate_version", "(JIJIJI)I", (void *) netty_quiche_negotiate_version },
11771167
{ "quiche_retry", "(JIJIJIJIIJI)I", (void *) netty_quiche_retry },
11781168
{ "quiche_conn_set_qlog_path", "(JLjava/lang/String;Ljava/lang/String;Ljava/lang/String;)Z", (void *) netty_quiche_conn_set_qlog_path },

0 commit comments

Comments
 (0)