Support for `ring.swagger.json-schema/describe`

[christophe-riolo]

Hello,

In my project I have used ring.swagger.json-schema/describe to annotate some types

(require '[ring.swagger.json-schema :refer [describe]] '[schema.core :as s])
(s/defschema Foo (describe s/Str "Not very bar"))

However the schema-tools.swagger.core/transform failed on this

(require '[schema-tools.swagger.core])
(schema-tools.swagger.core/transform Foo nil)
;; Execution error (ExceptionInfo) at schema-tools.swagger.core/not-supported! (core.cljc:56).
;; don't know how to convert ring.swagger.json_schema.FieldSchema@8d6443 into a Swagger Schema. 

I have had to do the following

(import ring.swagger.json_schema.FieldSchema)
(extend-protocol schema-tools.swagger.core/SwaggerSchema
  FieldSchema
  (-transform [this opts]
    (schema-tools.swagger.core/transform (.schema this) opts)))

to get it working.

I am not sure if there should be support for this module in schema-tools, but at least it gave me some headache while trying to move from compojure-api to Reitit, so maybe it should be supported somewhere in the toolchain if I am not alone using that function !

[opqdonut]

That's a valid request! Doing cross-library-extends like this can be a bit tricky in Clojure unfortunately. Waiting to hear from other people who want this!

For the record, this is how you can set descriptions in schema-tools currently

(require '[schema.core :as s])
(require 'schema-tools.swagger.core 'schema-tools.core)
(s/defschema Foo (schema-tools.core/schema s/Str {:swagger/description "Not very bar"}))
(schema-tools.swagger.core/transform Foo nil)
; => {:type "string", :description "Not very bar"}