bugfix

Author: mevdschee

src/Tqdev/PhpCrudApi/Database/GenericReflection.php

@@ -106,7 +106,7 @@ private function getTableColumnsSQL(): string
                 return 'SELECT c.name AS "COLUMN_NAME", c.is_nullable AS "IS_NULLABLE", t.Name AS "DATA_TYPE", (c.max_length/2) AS "CHARACTER_MAXIMUM_LENGTH", c.precision AS "NUMERIC_PRECISION", c.scale AS "NUMERIC_SCALE", \'\' AS "COLUMN_TYPE" FROM sys.columns c INNER JOIN sys.types t ON c.user_type_id = t.user_type_id WHERE c.object_id = OBJECT_ID(?) AND \'\' <> ?';
             case 'sqlite':
                 $this->updateSqlLiteReflectionTables();
-                return 'SELECT "name" AS "COLUMN_NAME", case when "notnull"==1 then \'no\' else \'yes\' end as "IS_NULLABLE", "type" AS "DATA_TYPE", 2147483647 AS "CHARACTER_MAXIMUM_LENGTH", 0 AS "NUMERIC_PRECISION", 0 AS "NUMERIC_SCALE", \'\' AS "COLUMN_TYPE" FROM "sys/columns" WHERE "self" = ? AND \'\' <> ?';
+                return 'SELECT "name" AS "COLUMN_NAME", case when "notnull"==1 then \'no\' else \'yes\' end as "IS_NULLABLE", lower("type") AS "DATA_TYPE", 2147483647 AS "CHARACTER_MAXIMUM_LENGTH", 0 AS "NUMERIC_PRECISION", 0 AS "NUMERIC_SCALE", \'\' AS "COLUMN_TYPE" FROM "sys/columns" WHERE "self" = ? AND \'\' <> ?';
         }
     }
 
@@ -184,7 +184,7 @@ public function getTableColumns(string $tableName, string $type): array
         if ($this->driver == 'mysql') {
             foreach ($results as &$result) {
                 // mysql does not properly reflect display width of types
-                preg_match('|([a-zA-Z]+)(\(([0-9]+)(,([0-9]+))?\))?|', $result['DATA_TYPE'], $matches);
+                preg_match('|([a-z]+)(\(([0-9]+)(,([0-9]+))?\))?|', $result['DATA_TYPE'], $matches);
                 $result['DATA_TYPE'] = $matches[1];
                 if (!$result['CHARACTER_MAXIMUM_LENGTH']) {
                     if (isset($matches[3])) {
@@ -198,8 +198,8 @@ public function getTableColumns(string $tableName, string $type): array
         }
         if ($this->driver == 'sqlite') {
             foreach ($results as &$result) {
-                // mysql does not properly reflect display width of types
-                preg_match('|([a-zA-Z]+)(\(([0-9]+)(,([0-9]+))?\))?|', $result['DATA_TYPE'], $matches);
+                // sqlite does not properly reflect display width of types
+                preg_match('|([a-z]+)(\(([0-9]+)(,([0-9]+))?\))?|', $result['DATA_TYPE'], $matches);
                 if (isset($matches[1])) {
                     $result['DATA_TYPE'] = $matches[1];
                 } else {

tests/fixtures/blog_sqlite.sql

@@ -17,7 +17,7 @@ DROP TABLE IF EXISTS "comments";
 CREATE TABLE "comments" (
   "id" integer NOT NULL PRIMARY KEY AUTOINCREMENT,
   "post_id" integer NOT NULL,
-  "message" varchar(255) NOT NULL,
+  "message" VARCHAR(255) NOT NULL,
   "category_id" integer NOT NULL,
   FOREIGN KEY ("post_id") REFERENCES "posts" ("id") ON DELETE RESTRICT ON UPDATE RESTRICT,
   FOREIGN KEY ("category_id") REFERENCES "categories" ("id") ON DELETE RESTRICT ON UPDATE RESTRICT