comment for #769

mevdschee · mevdschee · commit 4e73a49808f0 · 2021-03-16T11:24:57.000+01:00
diff --git a/src/Tqdev/PhpCrudApi/Database/GenericReflection.php b/src/Tqdev/PhpCrudApi/Database/GenericReflection.php
@@ -151,7 +151,7 @@ public function getTableColumns(string $tableName, string $type): array
         }
         if ($this->driver == 'sqlite') {
             foreach ($results as &$result) {
-                // sqlite does not properly reflect display width of types
+                // sqlite does not reflect types on view columns
                 preg_match('|([a-z]+)(\(([0-9]+)(,([0-9]+))?\))?|', $result['DATA_TYPE'], $matches);
                 if (isset($matches[1])) {
                     $result['DATA_TYPE'] = $matches[1];

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ public function getTableColumns(string $tableName, string $type): array`
`151`	`151`	`}`
`152`	`152`	`if ($this->driver == 'sqlite') {`
`153`	`153`	`foreach ($results as &$result) {`
`154`		`- // sqlite does not properly reflect display width of types`
	`154`	`+ // sqlite does not reflect types on view columns`
`155`	`155`	`preg_match('\|([a-z]+)(\(([0-9]+)(,([0-9]+))?\))?\|', $result['DATA_TYPE'], $matches);`
`156`	`156`	`if (isset($matches[1])) {`
`157`	`157`	`$result['DATA_TYPE'] = $matches[1];`