Skip to content

Commit 7bee184

Browse files
committed
use PSR-7 for Firewall middleware
1 parent 87fa693 commit 7bee184

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

api.include.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7935,12 +7935,11 @@ private function isIpAllowed(string $ipAddress, string $allowedIpAddresses): boo
79357935
public function process(ServerRequestInterface $request, RequestHandlerInterface $next): ResponseInterface
79367936
{
79377937
$reverseProxy = $this->getProperty('reverseProxy', '');
7938+
$serverParams = $request->getServerParams();
79387939
if ($reverseProxy) {
7939-
$ipAddress = array_pop(explode(',', $request->getHeader('X-Forwarded-For')));
7940-
} elseif (isset($_SERVER['REMOTE_ADDR'])) {
7941-
$ipAddress = $_SERVER['REMOTE_ADDR'];
7940+
$ipAddress = array_pop($request->getHeader('X-Forwarded-For'));
79427941
} else {
7943-
$ipAddress = '127.0.0.1';
7942+
$ipAddress = $serverParams['REMOTE_ADDR'] ?? '127.0.0.1';
79447943
}
79457944
$allowedIpAddresses = $this->getProperty('allowedIpAddresses', '');
79467945
if (!$this->isIpAllowed($ipAddress, $allowedIpAddresses)) {

api.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7935,12 +7935,11 @@ private function isIpAllowed(string $ipAddress, string $allowedIpAddresses): boo
79357935
public function process(ServerRequestInterface $request, RequestHandlerInterface $next): ResponseInterface
79367936
{
79377937
$reverseProxy = $this->getProperty('reverseProxy', '');
7938+
$serverParams = $request->getServerParams();
79387939
if ($reverseProxy) {
7939-
$ipAddress = array_pop(explode(',', $request->getHeader('X-Forwarded-For')));
7940-
} elseif (isset($_SERVER['REMOTE_ADDR'])) {
7941-
$ipAddress = $_SERVER['REMOTE_ADDR'];
7940+
$ipAddress = array_pop($request->getHeader('X-Forwarded-For'));
79427941
} else {
7943-
$ipAddress = '127.0.0.1';
7942+
$ipAddress = $serverParams['REMOTE_ADDR'] ?? '127.0.0.1';
79447943
}
79457944
$allowedIpAddresses = $this->getProperty('allowedIpAddresses', '');
79467945
if (!$this->isIpAllowed($ipAddress, $allowedIpAddresses)) {

src/Tqdev/PhpCrudApi/Middleware/FirewallMiddleware.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,11 @@ private function isIpAllowed(string $ipAddress, string $allowedIpAddresses): boo
3939
public function process(ServerRequestInterface $request, RequestHandlerInterface $next): ResponseInterface
4040
{
4141
$reverseProxy = $this->getProperty('reverseProxy', '');
42+
$serverParams = $request->getServerParams();
4243
if ($reverseProxy) {
43-
$ipAddress = array_pop(explode(',', $request->getHeader('X-Forwarded-For')));
44-
} elseif (isset($_SERVER['REMOTE_ADDR'])) {
45-
$ipAddress = $_SERVER['REMOTE_ADDR'];
44+
$ipAddress = array_pop($request->getHeader('X-Forwarded-For'));
4645
} else {
47-
$ipAddress = '127.0.0.1';
46+
$ipAddress = $serverParams['REMOTE_ADDR'] ?? '127.0.0.1';
4847
}
4948
$allowedIpAddresses = $this->getProperty('allowedIpAddresses', '');
5049
if (!$this->isIpAllowed($ipAddress, $allowedIpAddresses)) {

0 commit comments

Comments
 (0)