Skip to content

Commit a891e07

Browse files
committed
Use session_regenerate_id() to prevent fixation attacks
1 parent 18bc1f1 commit a891e07

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/Tqdev/PhpCrudApi/Middleware/BasicAuthMiddleware.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ public function handle(Request $request): Response
9090
if (!$validUser) {
9191
return $this->responder->error(ErrorCode::AUTHENTICATION_FAILED, $username);
9292
}
93+
session_regenerate_id();
9394
}
9495
if (!isset($_SESSION['username']) || !$_SESSION['username']) {
9596
$authenticationMode = $this->getProperty('mode', 'required');

src/Tqdev/PhpCrudApi/Middleware/JwtAuthMiddleware.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ public function handle(Request $request): Response
107107
if (empty($claims)) {
108108
return $this->responder->error(ErrorCode::AUTHENTICATION_FAILED, 'JWT');
109109
}
110+
session_regenerate_id();
110111
}
111112
if (empty($_SESSION['claims'])) {
112113
$authenticationMode = $this->getProperty('mode', 'required');

0 commit comments

Comments
 (0)