Remove reflection

Author: mevdschee

tests/Config.php.dist

@@ -9,30 +9,26 @@ class Config
      * @var array
      */
     public static $config = array(
-        array(
-            'dbengine' => 'MySQL',              // 'MySQL', 'SQLServer', 'PostgreSQL' or 'SQLite'
+        'MySQL' => array(
             'hostname' => '{{test_hostname}}',  // 'localhost' for MySQL, '(Local)' for SQLServer, empty for SQLite
             'username' => '{{test_username}}',  // May be empty on SQLServer or SQLite
             'password' => '{{test_password}}',  // May be empty on SQLServer or SQLite
             'database' => '{{test_database}}',  // NB: Use an empty database, data will be LOST!
         ),
         /* Uncomment and update for any databases you want to use.
-        array(
-            'dbengine' => 'PostgreSQL',
+        'PostgreSQL' => array(
             'hostname' => '{{test_hostname}}',
             'username' => '{{test_username}}',
             'password' => '{{test_password}}',
             'database' => '{{test_database}}',
         ),
-        array(
-            'dbengine' => 'SQLite',
+        'SQLite' => array(
             'hostname' => '{{test_hostname}}',
             'username' => '{{test_username}}',
             'password' => '{{test_password}}',
             'database' => '{{test_database}}',
         ),
-        array(
-            'dbengine' => 'SQLServer',
+        'SQLServer' => array(
             'hostname' => '{{test_hostname}}',
             'username' => '{{test_username}}',
             'password' => '{{test_password}}',

tests/Config.php.travis

@@ -9,27 +9,19 @@ class Config
      * @var array
      */
     public static $config = array(
-        /* MySQL is disabled because v5.7 is required for all tests to pass,
-            and Travis only has up to MySQL 5.6 installed by default. This
-            will be runnable once we have a test suite that adapts to the
-            available MySQL version. See: https://github.com/mevdschee/php-crud-api/issues/194
-        array(
-            'dbengine' => 'MySQL',
+        'MySQL' => array(
             'hostname' => 'localhost',
             'username' => 'root',
             'password' => 'travis',
             'database' => 'testing',
         ),
-        */
-        array(
-            'dbengine' => 'PostgreSQL',
+        'PostgreSQL' => array(
             'hostname' => 'localhost',
             'username' => 'postgres',
             'password' => '',
             'database' => 'testing',
         ),
-        array(
-            'dbengine' => 'SQLite',
+        'SQLite' => array(
             'hostname' => '',
             'username' => '',
             'password' => '',

tests/MysqlTest.php

@@ -4,6 +4,8 @@
 
 class MysqlTest extends Tests
 {
+    const NAME = 'MySQL';
+
     /**
      * Connects to the Database
      *

tests/PostgresqlTest.php

@@ -4,6 +4,8 @@
 
 class PostgresqlTest extends Tests
 {
+    const NAME = 'PostgreSQL';
+
     /**
      * Connects to the Database
      *

tests/SqlServerTest.php

@@ -4,6 +4,8 @@
 
 class SqlServerTest extends Tests
 {
+    const NAME = 'SQLServer';
+
     /**
      * Connects to the Database
      *

tests/SqliteTest.php

@@ -4,6 +4,8 @@
 
 class SqliteTest extends Tests
 {
+    const NAME = 'SQLite';
+
     /**
      * Connects to the Database
      *

tests/TestBase.php

@@ -4,23 +4,12 @@
 
 abstract class TestBase extends PHPUnit_Framework_TestCase
 {
-    protected function getConfig()
-    {
-        $dbengine = strtolower(substr(get_called_class(),0,-4));
-        foreach (Config::$config as $database) {
-            if (strtolower($database['dbengine']) == $dbengine) {
-                if ($database['database']!='{{test_database}}') {
-                    return $database;
-                }
-            }
-        }
-        self::markTestSkipped("Configuration for '{$dbengine}' in 'Config.php' not found.");
-        return false;
-    }
-
     public static function setUpBeforeClass()
     {
-        $config = self::getConfig();
+        if (!Config::$config || !isset(Config::$config[static::NAME])) {
+            self::markTestSkipped("Configuration in 'Config.php' not found.");
+        }
+        $config = Config::$config[static::NAME];
         $db = static::connect($config);
         static::checkVersion($db);
         $capabilities = static::getCapabilities($db);
@@ -37,6 +26,10 @@ public static function setUpBeforeClass()
     const GIS = 1;
     const JSON = 2;
 
+    public abstract function connect($db);
+
+    public abstract function disconnect($db);
+
     public abstract function checkVersion($db);
 
     public abstract function getCapabilities($db);