TypeError: Cannot read properties of undefined (reading 'name') when running mmm scan with unmanaged mods present #1005
Description
What happened?
When running mmm scan on a Fabric 1.21.10 mod folder, the process crashes with a TypeError: Cannot read properties of undefined (reading 'name').
pauln @ optiplex in ~/abicraft |20:05:40
$ mmm scan
✅Found unmanaged mod: No Chat Reports
✅Found unmanaged mod: ScalableLux
✅Found unmanaged mod: AntiXray
✅Found unmanaged mod: Hey That's Mine
✅Found unmanaged mod: Text Placeholder API
✅Found unmanaged mod: Styled Chat
✅Found unmanaged mod: Styled Player List
✅Found unmanaged mod: Lithium
✅Found unmanaged mod: Ouch!
✅Found unmanaged mod: LuckPerms
✅Found unmanaged mod: Universal Shops
✅Found unmanaged mod: Fabric API
node:internal/process/task_queues:95
runMicrotasks();
^
TypeError: Cannot read properties of undefined (reading 'name')
at /snapshot/minecraft-mod-manager/dist/mmm.cjs
at Array.forEach (<anonymous>)
at processScanResults (/snapshot/minecraft-mod-manager/dist/mmm.cjs)
at scan2 (/snapshot/minecraft-mod-manager/dist/mmm.cjs)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async _Command.<anonymous> (/snapshot/minecraft-mod-manager/dist/mmm.cjs)
at async _Command.parseAsync (/snapshot/minecraft-mod-manager/dist/mmm.cjs)
Node.js v20.10.0
here's the contents of my ./mods
pauln @ optiplex in ~/abicraft |20:08:18
$ ls mods/ -lha
total 38M
drwxrwxrwx 2 pauln pauln 4,0K Okt 20 20:05 .
drwxrwxr-x 16 pauln pauln 4,0K Okt 20 20:05 ..
-rw-r--r-- 1 pauln pauln 142K Okt 10 19:40 antixray-fabric-1.4.10+1.21.9.jar
-rw-r--r-- 1 pauln pauln 4,5M Okt 10 19:40 c2me-fabric-mc1.21.10-0.3.5+beta.1.0.jar
-rw-r--r-- 1 pauln pauln 2,2M Okt 10 19:26 fabric-api-0.135.0+1.21.10.jar
-rw-r--r-- 1 pauln pauln 7,2M Okt 11 17:50 fabric-language-kotlin-1.13.6+kotlin.2.2.20.jar
-rw-r--r-- 1 pauln pauln 2,6M Okt 10 19:23 Floodgate-Fabric-2.2.6-b49.jar
-rw-r--r-- 1 pauln pauln 5,6M Okt 20 15:13 fuji-fabric-12.68.0-72cfd00271-mc1.21.10.jar
-rw-r--r-- 1 pauln pauln 212K Okt 20 16:07 htm-1.2.0.jar
-rw-r--r-- 1 pauln pauln 811K Okt 10 19:41 lithium-fabric-0.20.0+mc1.21.10.jar
-rw-r--r-- 1 pauln pauln 1,6M Okt 13 16:50 LuckPerms-Fabric-5.5.17.jar
-rw-r--r-- 1 pauln pauln 244K Okt 19 21:01 NoChatReports-FABRIC-1.21.10-v2.16.0.jar
-rw-r--r-- 1 pauln pauln 600K Okt 19 19:23 ouch-1.6.0+1.21.9-rc1.jar
-rw-r--r-- 1 pauln pauln 259K Okt 19 20:05 placeholder-api-2.8.0+1.21.9.jar
-rw-r--r-- 1 pauln pauln 179K Okt 10 19:41 ScalableLux-0.1.6+fabric.c25518a-all.jar
-rw-r--r-- 1 pauln pauln 3,7M Okt 20 16:04 spark-1.10.152-fabric.jar
-rw-r--r-- 1 pauln pauln 508K Okt 13 20:52 styled-chat-2.10.0+1.21.9.jar
-rw-r--r-- 1 pauln pauln 388K Okt 19 18:51 styledplayerlist-3.9.0+1.21.9.jar
-rw-r--r-- 1 pauln pauln 1,7M Okt 20 15:13 universal_shops-1.12.0+1.21.9.jar
-rw-r--r-- 1 pauln pauln 5,3M Okt 10 19:41 voicechat-fabric-1.21.10-2.6.5.jar
What did you expect to happen?
I expected mmm scan to automatically add unmanaged mods to modlist.json instead of crashing.
Which command did you run?
mmm scan
Operating System
Linux
What version of MMM are you running?
2.0.12
Contents of the modlist.json
{
"loader": "fabric",
"gameVersion": "1.21.10",
"defaultAllowedReleaseTypes": [
"beta",
"release"
],
"modsFolder": "./mods",
"mods": []
}Contents of the modlist-lock.json
[]I have updated
- I swear I have tried it with the latest version!