updated Helper class name to Logger

Author: mfaisalkhatri

src/test/java/io/github/mfaisalkhatri/api/restfulecommerce/HappyPathTests.java

@@ -38,8 +38,8 @@ public void testShouldCreateNewOrders() throws JsonProcessingException {
 
         final APIResponse response = this.request.post("/addOrder", RequestOptions.create()
                 .setData(this.orderList));
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         final JSONObject responseObject = new JSONObject(response.text());
         final JSONArray ordersArray = responseObject.getJSONArray("orders");
@@ -57,8 +57,8 @@ public void testShouldGetAllOrders() {
 
         final APIResponse response = this.request.get("/getAllOrders");
 
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         final JSONObject responseObject = new JSONObject(response.text());
         final JSONArray ordersArray = responseObject.getJSONArray("orders");
@@ -75,8 +75,8 @@ public void testShouldGetOrderUsingOrderId() {
         final int orderId = 1;
         final APIResponse response = this.request.get("/getOrder", RequestOptions.create().setQueryParam("id", orderId));
 
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         final JSONObject responseObject = new JSONObject(response.text());
         final JSONArray ordersArray = responseObject.getJSONArray("orders");
@@ -93,8 +93,8 @@ public void testShouldGetOrdersUsingUserId() {
 
         final APIResponse response = this.request.get("/getOrder", RequestOptions.create().setQueryParam("user_id", userId));
 
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         final JSONObject responseObject = new JSONObject(response.text());
         final JSONArray ordersArray = responseObject.getJSONArray("orders");
@@ -112,8 +112,8 @@ public void testShouldGetOrdersUsingProductId() {
 
         final APIResponse response = this.request.get("/getOrder", RequestOptions.create().setQueryParam("product_id", productId));
 
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         final JSONObject responseObject = new JSONObject(response.text());
         final JSONArray ordersArray = responseObject.getJSONArray("orders");
@@ -128,8 +128,8 @@ public void testShouldGetOrdersUsingProductId() {
     public void testTokenGeneration() {
         final APIResponse response = this.request.post("/auth", RequestOptions.create().setData(getCredentials()));
 
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         final JSONObject responseObject = new JSONObject(response.text());
 
@@ -153,8 +153,8 @@ public void testShouldUpdateTheOrderUsingPut() {
                 .setHeader("Authorization", token)
                 .setData(updatedOrder));
 
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         final JSONObject updateOrderResponseObject = new JSONObject(response.text());
         final JSONObject orderObject = updateOrderResponseObject.getJSONObject("order");
@@ -184,8 +184,8 @@ public void testShouldUpdateTheOrderUsingPatch() {
                 .setHeader("Authorization", token)
                 .setData(partialUpdatedOrder));
 
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         final JSONObject updateOrderResponseObject = new JSONObject(response.text());
         final JSONObject orderObject = updateOrderResponseObject.getJSONObject("order");
@@ -210,8 +210,8 @@ public void testShouldDeleteTheOrder() {
         final APIResponse response = this.request.delete("/deleteOrder/" + orderId, RequestOptions.create()
                 .setHeader("Authorization", token));
 
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         assertEquals(response.status(), 204);
     }
@@ -221,13 +221,13 @@ public void testShouldNotRetrieveDeletedOrder() {
         final int orderId = 1;
         final APIResponse response = this.request.get("/getOrder", RequestOptions.create().setQueryParam("id", orderId));
 
-        final Helper helper = new Helper(response);
-        helper.logResponseDetails();
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
 
         assertEquals(response.status(), 404);
 
         JSONObject jsonObject = new JSONObject(response.text());
         assertEquals(jsonObject.get("message"), "No Order found with the given parameters!");
     }
-    
+
 }

src/test/java/io/github/mfaisalkhatri/api/restfulecommerce/Helper.java renamed to src/test/java/io/github/mfaisalkhatri/api/restfulecommerce/Logger.java

@@ -4,15 +4,14 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.microsoft.playwright.APIResponse;
 import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
 
 
-public class Helper {
+public class Logger {
 
     private APIResponse response;
-    private Logger log;
+    private org.apache.logging.log4j.Logger log;
 
-    public Helper(APIResponse response) {
+    public Logger(APIResponse response) {
         this.response = response;
         log = LogManager.getLogger(getClass());
     }
@@ -21,7 +20,7 @@ public void logResponseDetails() {
 
         log.info("Response Headers: \n{}",response.headers());
         log.info("Status Code: {}", response.status());
-        if(response.text()!=null && !response.text().isEmpty() && !response.text().isBlank()) {
+        if(response.text()!=null && !response.text().isEmpty() && response.text().isBlank()) {
             log.info("Response Body: \n{}", prettyPrintJson(response.text()));
         }
 

test-suite/testng.xml

@@ -5,4 +5,4 @@
         <suite-file path="testng-reqres.xml"/>
         <suite-file path="testng-restfulbooker.xml"/>
     </suite-files>
-</suite> <!-- Suite -->
+</suite>