Skip to content

Commit 785e3c3

Browse files
mfaisalkhatrimfaisalkhatri
authored
Fixed reqrest tests by adding api key, updated versions of dependencies and plugins, formatting changes done. (#50)
* updated versions of dependencies in pom.xml * updated readme * updated plugin versions in pom.xml * added api key for reqres tests, added api key to secrets on github and updated maven workflow to use the api key from secret, made formatting changes to the testng xml files * updated correct image name for restful ecommerce
1 parent f74bdb2 commit 785e3c3

File tree

9 files changed

+27
-21
lines changed

9 files changed

+27
-21
lines changed

‎.github/workflows/maven.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ jobs:
4444
run: mvn clean install -DskipTests
4545

4646
- name: Run tests
47-
run: mvn clean test
47+
env:
48+
API_KEY: ${{ secrets.REQRES_API_KEY }}
49+
run: mvn clean test -Dapi-key=$API_KEY
4850

4951
- name: Stop restful booker service
5052
run: docker compose -f ./docker-compose-restfulbooker.yml down --remove-orphans

‎README.md‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,12 @@ You will get the answers to the following questions and its respective working c
4040
## :writing_hand: Blog Links
4141
- [What is API Testing?](https://mfaisalkhatri.github.io/2020/08/08/apitesting/)
4242
- [How to perform End to End API Testing using Playwright with Java and TestNG](https://medium.com/@iamfaisalkhatri/how-to-perform-end-to-end-api-testing-using-playwright-with-java-and-testng-26b318927115)
43-
- [Playwright Java API Testing | How to test POST requests?](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-post-requests-4c9102d3ab03)
44-
- [Playwright Java API Testing | How to test GET requests?](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-get-requests-c036b984cc6d)
45-
- [Playwright Java API Testing | How to test PUT requests?](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-put-requests-d6b1d054d64b)
46-
- [Playwright Java API Testing | How to test PATCH requests?](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-patch-requests-f6b0867d91e7)
47-
- [Playwright Java API Testing | How to test DELETE requests?](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-delete-requests-2ff77feb0383)
43+
- [How to test POST API requests with Playwright Java](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-post-requests-4c9102d3ab03)
44+
- [How to test GET API requests with Playwright Java](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-get-requests-c036b984cc6d)
45+
- [How to test PUT API requests with Playwright Java](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-put-requests-d6b1d054d64b)
46+
- [How to test PATCH API requests with Playwright Java](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-patch-requests-f6b0867d91e7)
47+
- [How to test DELETE API requests with Playwright Java](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-how-to-test-delete-requests-2ff77feb0383)
48+
- [How to Create a Custom Logger for Logging Response Details with Playwright Java](https://medium.com/@iamfaisalkhatri/playwright-java-api-testing-creating-custom-logger-for-logging-response-details-771e961d9faa)
4849

4950
## :question: Need Assistance?
5051

‎pom.xml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,20 @@
1212

1313
<properties>
1414
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
15-
<playwright-version>1.50.0</playwright-version>
15+
<playwright-version>1.52.0</playwright-version>
1616
<testng-version>7.11.0</testng-version>
1717
<hamcrest-all-version>1.3</hamcrest-all-version>
1818
<json-simple-version>1.1.1</json-simple-version>
19-
<lombok-version>1.18.36</lombok-version>
20-
<datafaker-version>2.4.2</datafaker-version>
21-
<gson-version>2.12.1</gson-version>
22-
<org-json-verion>20250107</org-json-verion>
23-
<jackson-databind-version>2.18.3</jackson-databind-version>
19+
<lombok-version>1.18.38</lombok-version>
20+
<datafaker-version>2.4.3</datafaker-version>
21+
<gson-version>2.13.1</gson-version>
22+
<org-json-verion>20250517</org-json-verion>
23+
<jackson-databind-version>2.19.0</jackson-databind-version>
2424
<log4j-core-version>2.24.1</log4j-core-version>
2525
<log4j-api-version>2.24.1</log4j-api-version>
2626
<commons-lang3-version>3.17.0</commons-lang3-version>
2727
<maven-compiler-plugin-version>3.14.0</maven-compiler-plugin-version>
28-
<maven-surefire-plugin-version>3.5.2</maven-surefire-plugin-version>
28+
<maven-surefire-plugin-version>3.5.3</maven-surefire-plugin-version>
2929
<java-release-version>17</java-release-version>
3030
<maven-enforcer-version>3.5.2</maven-enforcer-version>
3131
<suite-xml>test-suite/testng.xml</suite-xml>

‎src/test/java/io/github/mfaisalkhatri/api/reqres/tests/BaseTest.java‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
package io.github.mfaisalkhatri.api.reqres.tests;
22

3+
import java.util.HashMap;
4+
import java.util.Map;
5+
36
import io.github.mfaisalkhatri.api.manager.RequestManager;
47
import org.testng.annotations.AfterClass;
58
import org.testng.annotations.BeforeClass;
69

7-
import java.util.HashMap;
8-
import java.util.Map;
9-
1010
/**
1111
* @author Faisal Khatri
1212
* @since 2/28/2023
@@ -15,13 +15,16 @@ public class BaseTest {
1515

1616
protected RequestManager manager;
1717

18+
1819
@BeforeClass
1920
public void setup() {
21+
String apiKey = System.getProperty ("api-key");
2022
this.manager = new RequestManager();
2123
this.manager.createPlaywright();
2224
final String baseUrl = "https://reqres.in";
2325
final Map<String, String> headers = new HashMap<>();
2426
headers.put("content-type", "application/json");
27+
headers.put ("x-api-key", apiKey);
2528
this.manager.setApiRequestContext(baseUrl, headers);
2629
}
2730

‎test-suite/testng-reqres.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@
1414
</class>
1515
</classes>
1616
</test>
17-
</suite> <!-- Suite -->
17+
</suite>

‎test-suite/testng-restfulecommerce-deleteorders.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
</class>
1313
</classes>
1414
</test>
15-
</suite>
15+
</suite>

‎test-suite/testng-restfulecommerce-partialupdateorder.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
</class>
1212
</classes>
1313
</test>
14-
</suite>
14+
</suite>

‎test-suite/testng-restfulecommerce-postandgetorder.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
</class>
1212
</classes>
1313
</test>
14-
</suite>
14+
</suite>

‎test-suite/testng-restfulecommerce-updateorder.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@
2020
</class>
2121
</classes>
2222
</test>
23-
</suite>
23+
</suite>

0 commit comments

Comments
 (0)