updated happy and sad path tests

Author: mfaisalkhatri

src/test/java/io/github/mfaisalkhatri/api/restfulecommerce/HappyPathTests.java

@@ -20,6 +20,9 @@
 public class HappyPathTests extends BaseTest{
 
     private List<OrderData> orderList;
+    private int orderId;
+    private String userId;
+    private String productId;
 
     @BeforeClass
     public void testSetup() {
@@ -28,7 +31,7 @@ public void testSetup() {
 
     @Test
     public void testShouldPerformHealthCheckOfServer() {
-        final APIResponse response = this.request.get("/getAllOrders");
+        final APIResponse response = this.request.get("/health");
 
         final Logger logger = new Logger(response);
         logger.logResponseDetails();
@@ -62,6 +65,12 @@ public void testShouldCreateNewOrders() {
         assertEquals(this.orderList.get(0).getUserId(), ordersArray.getJSONObject(0).get("user_id"));
         assertEquals(this.orderList.get(0).getProductId(), ordersArray.getJSONObject(0).get("product_id"));
         assertEquals(this.orderList.get(0).getTotalAmt(), ordersArray.getJSONObject(0).get("total_amt"));
+
+        this.orderId = ordersArray.getJSONObject(0).getInt("id");
+        this.userId =ordersArray.getJSONObject(0).getString("user_id");
+        this.productId =ordersArray.getJSONObject(0).getString("product_id");
+
+
     }
 
     @Test
@@ -101,9 +110,8 @@ public void testShouldGetOrderUsingOrderId() {
 
     @Test
     public void testShouldGetOrdersUsingUserId() {
-        final String userId = "2";
 
-        final APIResponse response = this.request.get("/getOrder", RequestOptions.create().setQueryParam("user_id", userId));
+        final APIResponse response = this.request.get("/getOrder", RequestOptions.create().setQueryParam("user_id", this.userId));
 
         final Logger logger = new Logger(response);
         logger.logResponseDetails();
@@ -113,16 +121,14 @@ public void testShouldGetOrdersUsingUserId() {
 
         assertEquals(response.status(), 200);
         assertEquals(responseObject.get("message"), "Order found!!");
-        assertEquals(ordersArray.getJSONObject(0).get("user_id"), userId);
+        assertEquals(ordersArray.getJSONObject(0).get("user_id"), this.userId);
 
     }
 
     @Test
     public void testShouldGetOrdersUsingProductId() {
-        final String productId = "332";
-
 
-        final APIResponse response = this.request.get("/getOrder", RequestOptions.create().setQueryParam("product_id", productId));
+        final APIResponse response = this.request.get("/getOrder", RequestOptions.create().setQueryParam("product_id", this.productId));
 
         final Logger logger = new Logger(response);
         logger.logResponseDetails();
@@ -132,10 +138,35 @@ public void testShouldGetOrdersUsingProductId() {
 
         assertEquals(response.status(), 200);
         assertEquals(responseObject.get("message"), "Order found!!");
-        assertEquals(ordersArray.getJSONObject(0).get("product_id"), productId);
+        assertEquals(ordersArray.getJSONObject(0).get("product_id"), this.productId);
+
+    }
+
+    @Test
+    public void testShouldGetOrdersUsingOrderIdProductIdAndUserId() {
+
+        final APIResponse response = this.request.get("/getOrder", RequestOptions.create()
+                .setQueryParam("id", this.orderId)
+                .setQueryParam("product_id", this.productId)
+                .setQueryParam("user_id", this.userId));
+
+        final Logger logger = new Logger(response);
+        logger.logResponseDetails();
+
+        assertEquals(response.status(), 200);
+
+
+        final JSONObject responseObject = new JSONObject(response.text());
+        final JSONArray ordersArray = responseObject.getJSONArray("orders");
+
+        assertEquals(responseObject.get("message"), "Order found!!");
+        assertEquals(ordersArray.getJSONObject(0).get("id"), this.orderId);
+        assertEquals(ordersArray.getJSONObject(0).get("product_id"), this.productId);
+        assertEquals(ordersArray.getJSONObject(0).get("user_id"), this.userId);
 
     }
 
+
     @Test
     public void testTokenGeneration() {
         final APIResponse response = this.request.post("/auth", RequestOptions.create().setData(getCredentials()));
@@ -238,7 +269,7 @@ public void testShouldNotRetrieveDeletedOrder() {
 
         assertEquals(response.status(), 404);
 
-        JSONObject jsonObject = new JSONObject(response.text());
+        final JSONObject jsonObject = new JSONObject(response.text());
         assertEquals(jsonObject.get("message"), "No Order found with the given parameters!");
     }
 

src/test/java/io/github/mfaisalkhatri/api/restfulecommerce/SadPathTests.java

@@ -103,10 +103,4 @@ public void testShouldNotFetchOrder_WhenNoOrderExistsForProductId() {
         assertEquals(responseObject.get("message"), "No Order found with the given parameters!");
     }
 
-    @Test
-    public void testShouldNotGenerateToken_WhenInvalidCredentialsAreGiven() {
-
-
-    }
-
 }

test-suite/testng-restfulecommerce.xml

@@ -19,11 +19,13 @@
         <classes>
             <class name="io.github.mfaisalkhatri.api.restfulecommerce.HappyPathTests">
                 <methods>
+                    <include name="testShouldPerformHealthCheckOfServer"/>
                     <include name="testShouldCreateNewOrders"/>
                     <include name="testShouldGetAllOrders"/>
                     <include name="testShouldGetOrderUsingOrderId"/>
                     <include name="testShouldGetOrdersUsingUserId"/>
                     <include name="testShouldGetOrdersUsingProductId"/>
+                    <include name="testShouldGetOrdersUsingOrderIdProductIdAndUserId"/>
                     <include name="testTokenGeneration"/>
                     <include name="testShouldUpdateTheOrderUsingPut"/>
                     <include name="testShouldUpdateTheOrderUsingPatch"/>