Do not override kReattach for ::first-letter.

lilles · chromium-wpt-export-bot · commit 92bb4ac55a79 · 2018-06-18T12:33:13.000-04:00
We incorrectly did an override with kForce for ::first-letter recalc when we were already recalculating style for re-attachment (kReattach). This caused crashes in FirstLetterPseudoElement::DidRecalcStyle. Bug: 853621, 853476, 853471, 853470, 853433, 853411 Change-Id: Id34e6bdbaaeb3b4933a3e963b68f0bffcda0e40e Reviewed-on: https://chromium-review.googlesource.com/1104176 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#568006}
diff --git a/css/css-pseudo/first-letter-block-to-inline-ref.html b/css/css-pseudo/first-letter-block-to-inline-ref.html
@@ -0,0 +1,2 @@
+<!DOCTYPE html>
+<span style="color:green">This text should be green.</span>
diff --git a/css/css-pseudo/first-letter-block-to-inline.html b/css/css-pseudo/first-letter-block-to-inline.html
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<title>CSS Test: ::first-letter stops applying to element becoming inline.</title>
+<link rel="author" title="Rune Lillesveen" href="mailto:futhark@chromium.org">
+<link rel="match" href="first-letter-block-to-inline-ref.html">
+<link rel="help" href="https://drafts.csswg.org/css-pseudo-4/#first-letter-pseudo">
+<style>
+  #outer.block::first-letter { color: red }
+  #outer.block { display: block }
+</style>
+<span id="outer" class="block">
+  <span id="inner">This text should be green.</span>
+</span>
+<script>
+  outer.offsetTop;
+  outer.className = "";
+  inner.style.color = "green";
+</script>

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+<!DOCTYPE html>`
	`2`	`+<span style="color:green">This text should be green.</span>`