Skip to content

Commit f9b53c8

Browse files
Luke Bjerringchromium-wpt-export-bot
authored andcommitted
[idlharness.js] Add main interface as dep for implements
Case was revealed by web-platform-tests#9794 Specifically, Navigator implements NavigatorUserMedia; Navigator was not being added as a depenedency, and thus was not being imported. Change-Id: I07436c561bb0b567a431393a20f6a179ef5b364b Reviewed-on: https://chromium-review.googlesource.com/1104707 Reviewed-by: Robert Ma <[email protected]> Commit-Queue: Luke Bj <[email protected]> Cr-Commit-Position: refs/heads/master@{#568143}
1 parent 901c2f9 commit f9b53c8

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

resources/idlharness.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,10 @@ IdlArray.prototype.add_dependency_idls = function(raw_idls, options)
257257

258258
const all_deps = new Set();
259259
Object.values(this.inheritance).forEach(v => all_deps.add(v));
260-
Object.values(this.implements).forEach(v => all_deps.add(v));
260+
Object.entries(this.implements).forEach(([k, v]) => {
261+
all_deps.add(k);
262+
all_deps.add(v);
263+
});
261264
// NOTE: If 'A includes B' for B that we care about, then A is also a dep.
262265
Object.keys(this.includes).forEach(k => {
263266
all_deps.add(k);

0 commit comments

Comments
 (0)