fix validation

Author: mfbx9da4

package.json

@@ -1,6 +1,6 @@
 {
   "name": "deep-email-validator",
-  "version": "0.1.9",
+  "version": "0.1.11",
   "files": [
     "dist/**/*"
   ],

src/output/output.ts

@@ -29,6 +29,7 @@ export const createOutput = (
     const levelOut: SubOutputFormat = { valid }
     if (level === failLevel) {
       valid = false
+      levelOut.valid = false
       levelOut.reason = failReason
     }
     out.validators[level] = levelOut

test/__snapshots__/index.test.ts.snap

@@ -16,7 +16,7 @@ Object {
     },
     "smtp": Object {
       "reason": "The mail address that you specified was not syntactically correct.",
-      "valid": true,
+      "valid": false,
     },
     "typo": Object {
       "valid": true,
@@ -35,7 +35,7 @@ Object {
     },
     "mx": Object {
       "reason": "MX record not found",
-      "valid": true,
+      "valid": false,
     },
     "regex": Object {
       "valid": true,
@@ -66,7 +66,7 @@ Object {
     },
     "smtp": Object {
       "reason": "Invalid Mailbox",
-      "valid": true,
+      "valid": false,
     },
     "typo": Object {
       "valid": true,
@@ -91,7 +91,7 @@ Object {
     },
     "smtp": Object {
       "reason": "Invalid Mailbox",
-      "valid": true,
+      "valid": false,
     },
     "typo": Object {
       "valid": true,
@@ -113,7 +113,7 @@ Object {
     },
     "regex": Object {
       "reason": "Invalid regex",
-      "valid": true,
+      "valid": false,
     },
     "smtp": Object {
       "valid": false,
@@ -144,7 +144,7 @@ Object {
     },
     "typo": Object {
       "reason": "Likely typo, suggested email: [email protected]",
-      "valid": true,
+      "valid": false,
     },
   },
 }
@@ -157,7 +157,7 @@ Object {
   "validators": Object {
     "disposable": Object {
       "reason": "Email was created using a disposable email service",
-      "valid": true,
+      "valid": false,
     },
     "mx": Object {
       "valid": false,

test/index.test.ts

@@ -1,3 +1,5 @@
+import values from 'lodash/values'
+import every from 'lodash/every'
 import { validate } from '../src/index'
 
 const elevenSeconds = 11 * 1000
@@ -6,6 +8,8 @@ describe('validation tests', () => {
   it('fails with bad regex', async () => {
     const res = await validate('dav [email protected]')
     expect(res.valid).toBe(false)
+    expect(res.reason).toBe('regex')
+    expect(res.validators.regex?.valid).toBe(false)
     expect(res).toMatchSnapshot()
   })
 
@@ -15,18 +19,25 @@ describe('validation tests', () => {
       validateRegex: false,
     })
     expect(res.valid).toBe(false)
+    expect(res.reason).toBe('smtp')
+    expect(res.validators.regex?.valid).toBe(true)
+    expect(res.validators.smtp?.valid).toBe(false)
     expect(res).toMatchSnapshot()
   })
 
   it('fails with common typo', async () => {
     const res = await validate('[email protected]')
     expect(res.valid).toBe(false)
+    expect(res.reason).toBe('typo')
+    expect(res.validators.typo?.valid).toBe(false)
     expect(res).toMatchSnapshot()
   })
 
   it('fails with disposable email', async () => {
     const res = await validate('[email protected]')
     expect(res.valid).toBe(false)
+    expect(res.reason).toBe('disposable')
+    expect(res.validators.disposable?.valid).toBe(false)
     expect(res).toMatchSnapshot()
   })
 
@@ -35,6 +46,8 @@ describe('validation tests', () => {
     async () => {
       const res = await validate('[email protected]')
       expect(res.valid).toBe(false)
+      expect(res.reason).toBe('mx')
+      expect(res.validators.mx?.valid).toBe(false)
       expect(res).toMatchSnapshot()
     },
     elevenSeconds
@@ -43,6 +56,8 @@ describe('validation tests', () => {
   it('fails with bad mailbox', async () => {
     const res = await validate('[email protected]')
     expect(res.valid).toBe(false)
+    expect(res.reason).toBe('smtp')
+    expect(res.validators.smtp?.valid).toBe(false)
     expect(res).toMatchSnapshot()
   })
 
@@ -51,6 +66,8 @@ describe('validation tests', () => {
     async () => {
       const res = await validate('[email protected]')
       expect(res.valid).toBe(false)
+      expect(res.reason).toBe('smtp')
+      expect(res.validators.smtp?.valid).toBe(false)
       expect(res).toMatchSnapshot()
     },
     elevenSeconds
@@ -63,7 +80,8 @@ describe('validation tests', () => {
         email: '[email protected]',
         validateSMTP: false,
       })
-
+      expect(res.valid).toBe(true)
+      expect(every(values(res.validators), x => x && x.valid)).toBe(true)
       expect(res).toMatchSnapshot()
     },
     elevenSeconds
@@ -74,6 +92,7 @@ describe('validation tests', () => {
     async () => {
       const res = await validate('[email protected]')
       expect(res.valid).toBe(true)
+      expect(every(values(res.validators), x => x && x.valid)).toBe(true)
       expect(res).toMatchSnapshot()
     },
     elevenSeconds
@@ -84,6 +103,7 @@ describe('validation tests', () => {
     async () => {
       const res = await validate('[email protected]')
       expect(res.valid).toBe(true)
+      expect(every(values(res.validators), x => x && x.valid)).toBe(true)
       expect(res).toMatchSnapshot()
     },
     elevenSeconds