Skip to content

Commit 917a427

Browse files
committed
improve get best dns
1 parent a1b1ef7 commit 917a427

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Validates emails based on regex, common typos, disposable email blacklists, DNS records and SMTP server response.
44

5-
- Validates email is compliant with [RFC standard](https://tools.ietf.org/html/rfc2822#appendix-A.1.2) using regex.
5+
- Validates email is compliant with basic email format using regex.
66
- Validates common typos e.g. [email protected].
77
- Validates email was not generated by disposable email service.
88
- Validates MX records are present on DNS.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "deep-email-validator",
3-
"version": "0.1.15",
3+
"version": "0.1.16",
44
"files": [
55
"dist/**/*"
66
],

src/dns/dns.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,13 @@ export const getBestMx = async (
1313
domain: string
1414
): Promise<dns.MxRecord | undefined> => {
1515
const addresses = await getMx(domain)
16-
return addresses[0]
16+
let bestIndex = 0
17+
18+
for (let i = 0; i < addresses.length; i++) {
19+
if (addresses[i].priority < addresses[bestIndex].priority) {
20+
bestIndex = i
21+
}
22+
}
23+
24+
return addresses[bestIndex]
1725
}

0 commit comments

Comments
 (0)