Skip to content

Commit efa4e95

Browse files
authored
Merge pull request #157 from demin80/buffer-size-comparison-fix2
added type conversion to avoid signed-vs-unsigned-comparison warning
2 parents fb4c5ed + 755e9f1 commit efa4e95

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

include/cppkafka/utils/buffered_producer.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -708,6 +708,7 @@ bool BufferedProducer<BufferType, Allocator>::flush(std::chrono::milliseconds ti
708708
};
709709
re_enqueuer(retry_flush_queue, retry_messages_, retry_mutex_);
710710
re_enqueuer(flush_queue, messages_, mutex_);
711+
return true;
711712
}
712713
else {
713714
async_flush();
@@ -811,7 +812,7 @@ void BufferedProducer<BufferType, Allocator>::do_add_message(BuilderType&& build
811812

812813
// Flush the queues only if a regular message is added. Retry messages may be added
813814
// from rdkafka callbacks, and flush/async_flush is a user-level call
814-
if (queue_kind == QueueKind::Regular && flush_action == FlushAction::DoFlush && (max_buffer_size_ >= 0) && (max_buffer_size_ <= get_buffer_size())) {
815+
if (queue_kind == QueueKind::Regular && flush_action == FlushAction::DoFlush && (max_buffer_size_ >= 0) && (max_buffer_size_ <= (ssize_t)get_buffer_size())) {
815816
if (flush_method_ == FlushMethod::Sync) {
816817
flush();
817818
}

0 commit comments

Comments
 (0)