Add additional validation to command name

Author: mfridman

parse.go

@@ -4,7 +4,9 @@ import (
 	"errors"
 	"flag"
 	"fmt"
+	"regexp"
 	"slices"
+	"strconv"
 	"strings"
 
 	"github.com/mfridman/xflag"
@@ -178,22 +180,32 @@ func Parse(root *Command, args []string) error {
 	return nil
 }
 
+var validNameRegex = regexp.MustCompile(`^[a-zA-Z]+$`)
+
+func validateName(root *Command) error {
+	if !validNameRegex.MatchString(root.Name) {
+		return fmt.Errorf("must contain only letters, no spaces or special characters")
+	}
+	return nil
+}
+
 func validateCommands(root *Command, path []string) error {
 	if root.Name == "" {
 		if len(path) == 0 {
 			return errors.New("root command has no name")
 		}
-		return fmt.Errorf("subcommand in path %q has no name", strings.Join(path, " "))
-	}
-	// Ensure name has no spaces
-	if strings.Contains(root.Name, " ") {
-		return fmt.Errorf("command name %q contains spaces, must be a single word", root.Name)
+		return fmt.Errorf("subcommand in path [%s] has no name", strings.Join(path, ", "))
 	}
 
-	// Add current command to path for nested validation
 	currentPath := append(path, root.Name)
+	if err := validateName(root); err != nil {
+		quoted := make([]string, len(currentPath))
+		for i, p := range currentPath {
+			quoted[i] = strconv.Quote(p)
+		}
+		return fmt.Errorf("command [%s]: %w", strings.Join(quoted, ", "), err)
+	}
 
-	// Recursively validate all subcommands
 	for _, sub := range root.SubCommands {
 		if err := validateCommands(sub, currentPath); err != nil {
 			return err

parse_test.go

@@ -308,7 +308,7 @@ func TestParse(t *testing.T) {
 
 		err := Parse(s.root, nil)
 		require.Error(t, err)
-		require.ErrorContains(t, err, `subcommand in path "todo nested" has no name`)
+		require.ErrorContains(t, err, `subcommand in path [todo, nested] has no name`)
 	})
 	t.Run("required flag", func(t *testing.T) {
 		t.Parallel()
@@ -368,6 +368,6 @@ func TestParse(t *testing.T) {
 		}
 		err := Parse(cmd, nil)
 		require.Error(t, err)
-		require.ErrorContains(t, err, `command name "sub command" contains spaces, must be a single word`)
+		require.ErrorContains(t, err, `failed to parse: command ["root", "sub command"]: must contain only letters, no spaces or special characters`)
 	})
 }