BiomeJS line processing missing all diagnostics

[dannyfritz]

I noticed that the processing for biomejs lines isn't correct. Not sure if the biome reporter changed over time or why this is the case, but currently biomejs does not return diagnostics to neovim when it should. I poked around enough to see the problem lies here. I am willing to work on this myself, but want to make sure I'm understanding that this is a problem. There are structured reporters biomejs can output I would switch to.

Sample biomejs output I'm seeing:

> biome lint
biome.json:2:13 deserialize ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ℹ The configuration schema version does not match the CLI version 2.3.7

    1 │ {
  > 2 │         "$schema": "https://biomejs.dev/schemas/2.3.0/schema.json",
      │                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    3 │         "vcs": {
    4 │                 "enabled": true,

  ℹ   Expected:                     2.3.7
      Found:                        2.3.0


  ℹ Run the command biome migrate to migrate the configuration file.


src/examples/findApp.ts:223:5 lint/style/useTemplate  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ℹ Template literals are preferred over string concatenation.

    221 │               } else {
    222 │                       this.graphics.text(
  > 223 │                               "Digs Left:" + this.state.action_points,
        │                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    224 │                               this.graphics.matrixPool.get(),
    225 │                               {},

  ℹ Unsafe fix: Use a template literal.

    221 221 │                   } else {
    222 222 │                           this.graphics.text(
    223     │ - → → → → "Digs·Left:"·+·this.state.action_points,
        223 │ + → → → → `Digs·Left:${this.state.action_points}`,
    224 224 │                                   this.graphics.matrixPool.get(),
    225 225 │                                   {},


Checked 22 files in 93ms. No fixes applied.
Found 2 infos.

[dannyfritz]

I have a working parser using the "github" reporter. I would have liked to use the "json" reporter, but it did not include line numbers and is marked as unstable/beta. The "github" reporter was first available June 2024 in v1.8.0.

--[[
-- Sample output with the "github" reporter
-- "::notice title=lint/style/useTemplate,file=src/examples/findApp.ts,line=223,endLine=223,col=5,endColumn=44::Template literals are preferred over string concatenation."
--]]
local binary_name = "biome"

local severity_map = {
  ["error"] = vim.diagnostic.severity.ERROR,
  ["warn"] = vim.diagnostic.severity.WARN,
  ["notice"] = vim.diagnostic.severity.INFO,
}

return {
  cmd = function()
    local local_binary = vim.fn.fnamemodify('./node_modules/.bin/' .. binary_name, ':p')
    return vim.loop.fs_stat(local_binary) and local_binary or binary_name
  end,
  args = { "lint", "--reporter=github" },
  stdin = false,
  ignore_exitcode = true,
  stream = "stdout",
  parser = function(output)
    local diagnostics = {}
    for _, line in ipairs(vim.fn.split(output, "\n")) do
      local _, _, severity, category, file, lnum, lnum_end, col, col_end, description =
        string.find(line, "^::([^%s]+)%stitle=([^,]*),file=([^,]*),line=([^,]*),endLine=([^,]*),col=([^,]*),endColumn=([^,]*)::(.*)$")
      table.insert(diagnostics, {
        source = "biomejs",
        lnum = tonumber(lnum) - 1,
        end_lnum = tonumber(lnum_end) - 1,
        col = tonumber(col) - 1,
        end_col = tonumber(col_end) - 1,
        code = category,
        message = description,
        severity = severity_map[severity],
      })
    end
    return diagnostics
  end
}