Skip to content

Commit 2991434

Browse files
committed
Polish
1 parent 922c0ca commit 2991434

File tree

3 files changed

+23
-9
lines changed

3 files changed

+23
-9
lines changed

spring-boot-3-demo-app-reactive/src/main/java/io/github/mfvanek/spring/boot3/reactive/service/PublicApiService.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ private Mono<CurrentTime> getZonedTimeFromWorldTimeApi() {
5454
.bodyToMono(String.class)
5555
.retryWhen(prepareRetry(zoneName))
5656
.flatMap(this::convert)
57-
.doOnError(err -> log.warn("Received error response", err)) // TODO ???
5857
.onErrorComplete()
5958
.flatMap(Mono::justOrEmpty);
6059
}

spring-boot-3-demo-app-reactive/src/test/java/io/github/mfvanek/spring/boot3/reactive/service/PublicApiServiceTest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,6 @@ void printTimeZoneSuccessfully(@Nonnull final CapturedOutput output) {
5050
assertThat(result).isNotNull();
5151
assertThat(result.truncatedTo(ChronoUnit.MINUTES))
5252
.isEqualTo(localDateTimeNow.truncatedTo(ChronoUnit.MINUTES));
53-
assertThat(output.getAll())
54-
.contains("Request received:")
55-
.doesNotContain(
56-
"Retrying request to ",
57-
"Retries exhausted",
58-
"Failed to convert response ",
59-
"timezone");
6053
}
6154

6255
@Test

spring-boot-3-demo-app/src/test/java/io/github/mfvanek/spring/boot3/test/support/TestBase.java

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,20 @@
1616
import org.springframework.beans.factory.annotation.Autowired;
1717
import org.springframework.boot.test.autoconfigure.actuate.observability.AutoConfigureObservability;
1818
import org.springframework.boot.test.context.SpringBootTest;
19+
import org.springframework.boot.test.context.TestConfiguration;
1920
import org.springframework.cloud.contract.wiremock.AutoConfigureWireMock;
21+
import org.springframework.context.annotation.Bean;
22+
import org.springframework.context.annotation.Primary;
2023
import org.springframework.jdbc.core.JdbcTemplate;
2124
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
2225
import org.springframework.test.context.ActiveProfiles;
2326
import org.springframework.test.context.ContextConfiguration;
2427
import org.springframework.test.web.reactive.server.WebTestClient;
2528

2629
import java.time.Clock;
30+
import java.time.LocalDateTime;
31+
import java.time.Month;
32+
import java.time.ZoneOffset;
2733
import java.util.TimeZone;
2834
import javax.annotation.Nonnull;
2935

@@ -35,10 +41,16 @@
3541
@ActiveProfiles("test")
3642
@AutoConfigureObservability
3743
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
38-
@ContextConfiguration(initializers = {KafkaInitializer.class, JaegerInitializer.class, PostgresInitializer.class})
44+
@ContextConfiguration(
45+
classes = TestBase.CustomClockConfiguration.class,
46+
initializers = {KafkaInitializer.class, JaegerInitializer.class, PostgresInitializer.class}
47+
)
3948
@AutoConfigureWireMock(port = 0)
4049
public abstract class TestBase {
4150

51+
private static final ZoneOffset FIXED_ZONE = ZoneOffset.ofHours(-1);
52+
private static final LocalDateTime BEFORE_MILLENNIUM = LocalDateTime.of(1999, Month.DECEMBER, 31, 23, 59, 59);
53+
4254
@Autowired
4355
protected WebTestClient webTestClient;
4456
@Autowired
@@ -88,4 +100,14 @@ private void stubErrorResponse(@Nonnull final String zoneName, @Nonnull final Ru
88100
.withBody(objectMapper.writeValueAsString(errorForResponse))
89101
));
90102
}
103+
104+
@TestConfiguration
105+
static class CustomClockConfiguration {
106+
107+
@Bean
108+
@Primary
109+
public Clock fixedClock() {
110+
return Clock.fixed(BEFORE_MILLENNIUM.toInstant(FIXED_ZONE), FIXED_ZONE);
111+
}
112+
}
91113
}

0 commit comments

Comments
 (0)