exclude detect-formatting as it causes initialization error in tests

Author: m.zharinova

.kotlin/errors/errors-1745213070779.log

@@ -0,0 +1,4 @@
+kotlin version: 2.0.21
+error message: The daemon has terminated unexpectedly on startup attempt #1 with error code: 0. The daemon process output:
+    1. Kotlin compile daemon is ready
+

buildSrc/src/main/kotlin/sb-ot-demo.kotlin-conventions.gradle.kts

@@ -20,7 +20,7 @@ plugins {
 
 dependencies {
     implementation("org.jetbrains.kotlin:kotlin-reflect")
-    implementation("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
+    //implementation("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
     implementation("io.gitlab.arturbosch.detekt:detekt-rules-libraries:1.23.6")
 }
 
@@ -47,8 +47,6 @@ tasks {
         testLogging.showStandardStreams = false // set to true for debug purposes
     }
 }
-configurations.all {
-    exclude(group = "ch.qos.logback")
-}
+
 
 

spring-boot-3-demo-app-kotlin/build.gradle.kts

@@ -32,6 +32,7 @@ dependencies {
     implementation("com.github.blagerweij:liquibase-sessionlock")
     implementation("net.ttddyy.observation:datasource-micrometer-spring-boot:1.1.0")
     implementation("net.logstash.logback:logstash-logback-encoder:8.0")
+    implementation("io.github.oshai:kotlin-logging-jvm:7.0.0")
 
     testImplementation("org.springframework.boot:spring-boot-starter-test")
     testImplementation("org.springframework.boot:spring-boot-starter-webflux")

spring-boot-3-demo-app-kotlin/src/main/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/TimeController.kt

@@ -8,28 +8,28 @@ package io.github.mfvanek.spring.boot3.kotlin.test
 
 import io.github.mfvanek.spring.boot3.kotlin.test.service.KafkaSendingService
 import io.github.mfvanek.spring.boot3.kotlin.test.service.PublicApiService
+import io.github.oshai.kotlinlogging.KotlinLogging
 import io.micrometer.tracing.Tracer
-import mu.KotlinLogging
-import org.springframework.web.bind.annotation.GetMapping
-import org.springframework.web.bind.annotation.RestController
 import java.time.Clock
 import java.time.LocalDateTime
+import org.springframework.web.bind.annotation.GetMapping
+import org.springframework.web.bind.annotation.RestController
 
 private val logger = KotlinLogging.logger {}
 
 @RestController
-class TimeController (
+class TimeController(
     private val tracer: Tracer,
     private val clock: Clock,
     private val kafkaSendingService: KafkaSendingService,
     private val publicApiService: PublicApiService
-    ) {
+) {
 
     @GetMapping(path = ["/current-time"])
     fun getNow(): LocalDateTime {
-        logger.trace("tracer {}", tracer)
+        logger.trace { "tracer $tracer" }
         val traceId = tracer.currentSpan()?.context()?.traceId()
-        logger.info("Called method getNow. TraceId = {}", traceId)
+        logger.info { "Called method getNow. TraceId = $traceId" }
         val nowFromRemote = publicApiService.getZonedTime()
         val now = nowFromRemote ?: LocalDateTime.now(clock)
         kafkaSendingService.sendNotification("Current time = $now")

spring-boot-3-demo-app-kotlin/src/main/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/service/KafkaReadingService.kt

@@ -1,17 +1,17 @@
 package io.github.mfvanek.spring.boot3.kotlin.test.service
 
+import io.github.oshai.kotlinlogging.KotlinLogging
+import io.github.oshai.kotlinlogging.withLoggingContext
 import io.micrometer.tracing.Tracer
-import mu.KotlinLogging
+import java.time.Clock
+import java.time.LocalDateTime
+import java.util.UUID
 import org.apache.kafka.clients.consumer.ConsumerRecord
-import org.slf4j.MDC
 import org.springframework.beans.factory.annotation.Value
 import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate
 import org.springframework.kafka.annotation.KafkaListener
 import org.springframework.kafka.support.Acknowledgment
 import org.springframework.stereotype.Service
-import java.time.Clock
-import java.time.LocalDateTime
-import java.util.UUID
 
 private val logger = KotlinLogging.logger {}
 
@@ -23,11 +23,11 @@ class KafkaReadingService(
     private val jdbcTemplate: NamedParameterJdbcTemplate
 ) {
     @KafkaListener(topics = ["\${spring.kafka.template.default-topic}"])
-    fun listen(message: ConsumerRecord<UUID, String>, ack: Acknowledgment){
-        MDC.putCloseable("tenant.name", tenantName).use {
+    fun listen(message: ConsumerRecord<UUID, String>, ack: Acknowledgment) {
+        withLoggingContext("tenant.name" to tenantName) {
             val currentSpan = tracer.currentSpan()
             val traceId = currentSpan?.context()?.traceId() ?: ""
-            logger.info("Received record: {} with traceId {}", message.value(), traceId)
+            logger.info{"Received record: ${message.value()} with traceId $traceId"}
             jdbcTemplate.update(
                 "insert into otel_demo.storage(message, trace_id, created_at) values(:msg, :traceId, :createdAt);",
                 mapOf(

spring-boot-3-demo-app-kotlin/src/main/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/service/KafkaSendingService.kt

@@ -1,13 +1,13 @@
 package io.github.mfvanek.spring.boot3.kotlin.test.service
 
-import mu.KotlinLogging
-import org.slf4j.MDC
+import io.github.oshai.kotlinlogging.KotlinLogging
+import io.github.oshai.kotlinlogging.withLoggingContext
+import java.util.UUID
+import java.util.concurrent.CompletableFuture
 import org.springframework.beans.factory.annotation.Value
 import org.springframework.kafka.core.KafkaTemplate
 import org.springframework.kafka.support.SendResult
 import org.springframework.stereotype.Service
-import java.util.UUID
-import java.util.concurrent.CompletableFuture
 
 private val logger = KotlinLogging.logger {}
 
@@ -17,8 +17,8 @@ class KafkaSendingService(
     private val kafkaTemplate: KafkaTemplate<UUID, String>
 ) {
     fun sendNotification(message: String): CompletableFuture<SendResult<UUID, String>> {
-        MDC.putCloseable("tenant.name", tenantName).use {
-            logger.info("Sending message \"{}\" to Kafka", message)
+        withLoggingContext("tenant.name" to tenantName) {
+            logger.info{"Sending message \"$message\" to Kafka"}
             return kafkaTemplate.sendDefault(UUID.randomUUID(), message)
         }
     }

spring-boot-3-demo-app-kotlin/src/main/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/service/PublicApiService.kt

@@ -11,17 +11,17 @@ import com.fasterxml.jackson.databind.ObjectMapper
 import io.github.mfvanek.spring.boot3.kotlin.test.service.dto.CurrentTime
 import io.github.mfvanek.spring.boot3.kotlin.test.service.dto.ParsedDateTime
 import io.github.mfvanek.spring.boot3.kotlin.test.service.dto.toLocalDateTime
-import mu.KotlinLogging
-import org.slf4j.MDC
+import java.time.Duration
+import java.time.LocalDateTime
+import java.util.TimeZone
+import io.github.oshai.kotlinlogging.KotlinLogging
+import io.github.oshai.kotlinlogging.withLoggingContext
 import org.springframework.beans.factory.annotation.Value
 import org.springframework.http.MediaType
 import org.springframework.retry.ExhaustedRetryException
 import org.springframework.stereotype.Service
 import org.springframework.web.reactive.function.client.WebClient
 import reactor.util.retry.Retry
-import java.time.Duration
-import java.time.LocalDateTime
-import java.util.TimeZone
 
 private val logger = KotlinLogging.logger {}
 
@@ -36,9 +36,9 @@ class PublicApiService(
             val result: ParsedDateTime = getZonedTimeFromWorldTimeApi().datetime
             return result.toLocalDateTime()
         } catch (e: ExhaustedRetryException) {
-            logger.warn("Failed to get response", e)
+            logger.warn { "Failed to get response $e" }
         } catch (e: JsonProcessingException) {
-            logger.warn("Failed to convert response", e)
+            logger.warn { "Failed to convert response $e" }
         }
         return null
     }
@@ -57,15 +57,14 @@ class PublicApiService(
     private fun prepareRetry(zoneName: String): Retry {
         return Retry.fixedDelay(retries.toLong(), Duration.ofSeconds(2))
             .doBeforeRetry { retrySignal: Retry.RetrySignal ->
-                MDC.putCloseable("instance_timezone", zoneName).use {
-                    logger.info(
-                        "Retrying request to '/{}', attempt {}/{} due to error:",
-                        zoneName, retrySignal.totalRetries() + 1, retries, retrySignal.failure()
-                    )
+                withLoggingContext("instance_timezone" to zoneName) {
+                    logger.info {
+                        "Retrying request to '/$zoneName', attempt ${retrySignal.totalRetries() + 1}/${retrySignal.failure()} due to error:"
+                    }
                 }
             }
             .onRetryExhaustedThrow { _, retrySignal: Retry.RetrySignal ->
-                logger.error("Request to '/{}' failed after {} attempts.", zoneName, retrySignal.totalRetries() + 1)
+                logger.error { "Request to '/$zoneName' failed after ${retrySignal.totalRetries() + 1} attempts." }
                 ExhaustedRetryException("Retries exhausted", retrySignal.failure())
             }
     }